[Fix] forbid-prop-types: properly report name in error message; check undestructured arguments

Fixes #2945

Author: ljharb

CHANGELOG.md

@@ -27,6 +27,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 * [`function-component-definition`]: do not break on dollar signs ([#3207][] @ljharb)
 * [`prefer-stateless-function`]: avoid a crash inside `doctrine` ([#2596][] @ljharb)
 * [`prop-types`]: catch infinite loop ([#2861][] @ljharb)
+* [`forbid-prop-types`]: properly report name in error message; check undestructured arguments ([#2945][] @ljharb)
 
 ### Changed
 * [readme] change [`jsx-runtime`] link from branch to sha ([#3160][] @tatsushitoji)
@@ -56,6 +57,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 [#3163]: https://github.com/yannickcr/eslint-plugin-react/pull/3163
 [#3160]: https://github.com/yannickcr/eslint-plugin-react/pull/3160
 [#3133]: https://github.com/yannickcr/eslint-plugin-react/pull/3133
+[#2945]: https://github.com/yannickcr/eslint-plugin-react/issues/2945
 [#2921]: https://github.com/yannickcr/eslint-plugin-react/pull/2921
 [#2861]: https://github.com/yannickcr/eslint-plugin-react/issues/2861
 [#2813]: https://github.com/yannickcr/eslint-plugin-react/pull/2813

lib/rules/forbid-prop-types.js

@@ -114,7 +114,8 @@ module.exports = {
           }
           if (value.type === 'CallExpression') {
             value.arguments.forEach((arg) => {
-              reportIfForbidden(arg.name, declaration, target);
+              const name = arg.type === 'MemberExpression' ? arg.property.name : arg.name;
+              reportIfForbidden(name, declaration, name);
             });
             value = value.callee;
           }

tests/lib/rules/forbid-prop-types.js

@@ -1719,5 +1719,55 @@ ruleTester.run('forbid-prop-types', rule, {
       `,
       errors: 1,
     },
+    {
+      code: `
+        import React from './React';
+
+        import { arrayOf, object } from 'prop-types';
+        
+        const App = ({ foo }) => (
+          <div>
+            Hello world {foo}
+          </div>
+        );
+        
+        App.propTypes = {
+          foo: arrayOf(object)
+        }
+        
+        export default App;
+      `,
+      errors: [
+        {
+          messageId: 'forbiddenPropType',
+          data: { target: 'object' },
+        },
+      ],
+    },
+    {
+      code: `
+        import React from './React';
+
+        import PropTypes, { arrayOf } from 'prop-types';
+        
+        const App = ({ foo }) => (
+          <div>
+            Hello world {foo}
+          </div>
+        );
+        
+        App.propTypes = {
+          foo: arrayOf(PropTypes.object)
+        }
+        
+        export default App;
+      `,
+      errors: [
+        {
+          messageId: 'forbiddenPropType',
+          data: { target: 'object' },
+        },
+      ],
+    },
   ]),
 });