-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Hi,
Please fix the following issues:
- In the code, SignCheck/index.js the function checkWinSync() invokes "CheckSign.exe" with command line but never captures the return error/success code from the binary. Maybe the exe wasn't written to return any. I think it would be better to return error code from CheckSign rather than just returning true or false.
- CheckSign.exe appears to be generated on VS2015 and compiled with dynamic linkage to CRT. Please update the actual binary to be statically compiled with CRT. VCRUNTIME140.dll will be missing by default on Win7/8.1 systems and hence the exe can't be invoked (missing dependency). This works fine on Win 10 since it has VCRT140.dll by default. Also, Win 7 x64 gets this dll after Windows update. So this should be fixed.

kami4ka and ashutoshbhadoria
Metadata
Metadata
Assignees
Labels
No labels