Skip to content

Commit e2dabdb

Browse files
authored
Merge pull request #122 from kcp-dev/no-more-envtest
replace setup-envtest with µget
2 parents 9db8bfe + b3f1538 commit e2dabdb

File tree

4 files changed

+25
-11
lines changed

4 files changed

+25
-11
lines changed

Makefile

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ clean:
7878

7979
.PHONY: clean-tools
8080
clean-tools:
81-
if [ -d $(UGET_DIRECTORY)/k8s ]; then chmod -R +w $(UGET_DIRECTORY)/k8s; fi
8281
rm -rf $(UGET_DIRECTORY)
8382
@echo "Cleaned $(UGET_DIRECTORY)."
8483

@@ -103,7 +102,8 @@ verify:
103102
### tools
104103

105104
BOILERPLATE_VERSION ?= 0.3.0
106-
ENVTEST_VERSION ?= release-0.19
105+
ENVTEST_ETCD_VERSION ?= 3.5.15
106+
ENVTEST_KUBE_VERSION ?= v1.34.2
107107
GIMPS_VERSION ?= 0.6.3
108108
GOIMPORTS_VERSION ?= c70783e636f2213cac683f6865d88c5edace3157
109109
GOLANGCI_LINT_VERSION ?= 2.1.6
@@ -125,8 +125,22 @@ install-boilerplate:
125125
@hack/uget.sh https://github.com/kubermatic-labs/boilerplate/releases/download/v{VERSION}/boilerplate_{VERSION}_{GOOS}_{GOARCH}.tar.gz boilerplate $(BOILERPLATE_VERSION)
126126

127127
.PHONY: install-envtest
128-
install-envtest:
129-
@GO_MODULE=true hack/uget.sh sigs.k8s.io/controller-runtime/tools/setup-envtest setup-envtest $(ENVTEST_VERSION)
128+
install-envtest: install-kube-apiserver install-etcd install-kubectl
129+
130+
.PHONY: install-kube-apiserver
131+
install-kube-apiserver:
132+
@UNCOMPRESSED=true hack/uget.sh https://dl.k8s.io/release/{VERSION}/bin/{GOOS}/{GOARCH}/kube-apiserver kube-apiserver $(ENVTEST_KUBE_VERSION) kube-apiserver
133+
134+
.PHONY: install-etcd
135+
install-etcd:
136+
@hack/uget.sh https://github.com/etcd-io/etcd/releases/download/v{VERSION}/etcd-v{VERSION}-{GOOS}-{GOARCH}.tar.gz etcd $(ENVTEST_ETCD_VERSION)
137+
138+
.PHONY: envtest-env
139+
envtest-env: export UGET_PRINT_PATH=absolute
140+
envtest-env:
141+
@echo "export TEST_ASSET_KUBE_APISERVER=$$(make --no-print-directory install-kube-apiserver)"
142+
@echo "export TEST_ASSET_ETCD=$$(make --no-print-directory install-etcd)"
143+
@echo "export TEST_ASSET_KUBECTL=$$(make --no-print-directory install-kubectl)"
130144

131145
GIMPS = $(UGET_DIRECTORY)/gimps-$(GIMPS_VERSION)
132146

@@ -189,7 +203,7 @@ install-reconciler-gen:
189203

190204
.PHONY: update-tools
191205
update-tools: UGET_UPDATE=true
192-
update-tools: clean-tools install-boilerplate install-gimps install-golangci-lint install-kubectl install-yq
206+
update-tools: clean-tools install-boilerplate install-gimps install-golangci-lint install-kubectl install-yq install-kcp install-kube-apiserver install-etcd
193207

194208
############################################################################
195209
### docs

hack/ci/run-e2e-tests.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ make build
3232

3333
# get kube envtest binaries
3434
echodate "Setting up Kube binaries…"
35-
ENVTEST="$(UGET_PRINT_PATH=relative make --no-print-directory install-envtest)"
36-
export KUBEBUILDER_ASSETS="$("$ENVTEST" use 1.31.0 --bin-dir _tools -p path)"
37-
KUBEBUILDER_ASSETS="$(realpath "$KUBEBUILDER_ASSETS")"
35+
source <(make --no-print-directory envtest-env)
3836

3937
# start a shared kcp process
4038
KCP="$(UGET_PRINT_PATH=relative make --no-print-directory install-kcp)"

hack/run-e2e-tests.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ source hack/lib.sh
2222

2323
# get kube envtest binaries
2424
echodate "Setting up Kube binaries…"
25-
ENVTEST="$(UGET_PRINT_PATH=relative make --no-print-directory install-envtest)"
26-
export KUBEBUILDER_ASSETS="$($ENVTEST use 1.31.0 --bin-dir $UGET_DIRECTORY -p path)"
27-
KUBEBUILDER_ASSETS="$(realpath "$KUBEBUILDER_ASSETS")"
25+
source <(make --no-print-directory envtest-env)
2826

2927
export ARTIFACTS=.e2e
3028

hack/tools.checksums

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
boilerplate|GOARCH=amd64;GOOS=linux|6f05fc3be207ae2ed99e125509a08df677cb007e197e16607c654a434b91d47f
22
boilerplate|GOARCH=arm64;GOOS=linux|70253486ed7a803a35a9abb2bab4db2f1f7748d5266bf7a1c2ee298fda2b208a
3+
etcd|GOARCH=amd64;GOOS=linux|435d74510f3216bab1932fb6d7a6b5fe8245301143fcd25f7e65dfb7dcf8904a
4+
etcd|GOARCH=arm64;GOOS=linux|cc8c645e5a8df0f35f2a5c51d9b9383037eef0cf0167c52e648457b3971a7a09
35
gimps|GOARCH=amd64;GOOS=linux|b597efc7e2c72097a44c001b41a06ccca97610963e1f1aec74c3d99c0e0b6c11
46
gimps|GOARCH=arm64;GOOS=linux|2588daec997b4f4b3a8d8875f780fd6faf3c39c933519e7899e19a686476c8e4
57
golangci-lint|GOARCH=amd64;GOOS=linux|7009324a8aad93c1f84dce1c3cf61181bdd6b68e5f1b8b5d6971662258255050
68
golangci-lint|GOARCH=arm64;GOOS=linux|c51ff5b21be688b043baea44de7dd855cf07b855c14f0de405bfaf922b1d7634
9+
kube-apiserver|GOARCH=amd64;GOOS=linux|ca822082ec39e54a25836a4011ddb66e482e317a7a4f1a1f73882bbd2cf5a2a1
10+
kube-apiserver|GOARCH=arm64;GOOS=linux|6ade6c2646e2c01fde1095407452afc2b65e89d6da16da29ee39f6223ccaf63b
711
kubectl|GOARCH=amd64;GOOS=linux|9591f3d75e1581f3f7392e6ad119aab2f28ae7d6c6e083dc5d22469667f27253
812
kubectl|GOARCH=arm64;GOOS=linux|95df604e914941f3172a93fa8feeb1a1a50f4011dfbe0c01e01b660afc8f9b85
913
yq|GOARCH=amd64;GOOS=linux|0c2b24e645b57d8e7c0566d18643a6d4f5580feeea3878127354a46f2a1e4598

0 commit comments

Comments
 (0)