Commit f2d74b3
authored
fix:
## 📜 Description
Fixed initial display of `KeyboardExtender` on Fabric (potentially iOS
26 specific only).
## 💡 Motivation and Context
When view is initially mounted, then `oldProps.enabled` and
`newProps.enabled` will be `true`, so we'll never update `_enabled` (the
only one case is to set it to `false` and then back to `true` on JS).
This fix is similar to
#1040
- we don't need to rely on old props and instead we need to compare with
our own internal state.
Closes
#1133
## 📢 Changelog
<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->
### iOS
- change `if (newViewProps.enabled != oldViewProps.enabled) {` to `if
(newViewProps.enabled != self.enabled) {`
## 🤔 How Has This Been Tested?
Tested on iPhone 16 Pro (iOS 26).
## 📸 Screenshots (if appropriate):
|Before|After|
|-------|-----|
|<img width="1206" height="2622" alt="image"
src="https://github.com/user-attachments/assets/f0167f56-d069-4d27-8a44-b4cdb061a01b"
/>|<img width="1206" height="2622" alt="image"
src="https://github.com/user-attachments/assets/fa290038-7d5e-45f4-8c95-81ac6d75d313"
/>|
## 📝 Checklist
- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changedKeyboardExtender initial mount on Fabric (#1135)1 parent 0a97fd6 commit f2d74b3
1 file changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
226 | 225 | | |
227 | 226 | | |
228 | | - | |
| 227 | + | |
229 | 228 | | |
230 | 229 | | |
231 | 230 | | |
| |||
0 commit comments