typechecker uses qualifiedFieldName

Author: krishagarwal278

pkg/analysis/numericbounds/analyzer.go

@@ -71,6 +71,7 @@ func run(pass *analysis.Pass) (any, error) {
 
 	inspect.InspectFields(func(field *ast.Field, _ extractjsontags.FieldTagInfo, markersAccess markershelper.Markers, qualifiedFieldName string) {
 		// Create TypeChecker with closure capturing markersAccess and qualifiedFieldName
+		// Ignore TypeChecker's prefix since we use qualifiedFieldName from inspector
 		typeChecker := utils.NewTypeChecker(func(pass *analysis.Pass, ident *ast.Ident, node ast.Node, _ string) {
 			checkNumericType(pass, ident, node, markersAccess, qualifiedFieldName)
 		})

pkg/analysis/numericbounds/testdata/src/a/a.go

@@ -145,10 +145,6 @@ type SliceFields struct {
 	InvalidSlice []int32 // want "SliceFields.InvalidSlice is missing minimum bound validation marker" "SliceFields.InvalidSlice is missing maximum bound validation marker"
 
 	InvalidSlice64 []int64 // want "SliceFields.InvalidSlice64 is missing minimum bound validation marker" "SliceFields.InvalidSlice64 is missing maximum bound validation marker"
-
-	// +kubebuilder:validation:items:Minimum=0
-	// +kubebuilder:validation:items:Maximum=100
-	ValidSliceWithBounds []int32
 }
 
 // TypeAliasFields with type aliases should be checked

pkg/analysis/utils/type_check.go

@@ -31,14 +31,14 @@ type TypeChecker interface {
 }
 
 // NewTypeChecker returns a new TypeChecker with the provided checkFunc.
-func NewTypeChecker(checkFunc func(pass *analysis.Pass, ident *ast.Ident, node ast.Node, prefix string)) TypeChecker {
+func NewTypeChecker(checkFunc func(pass *analysis.Pass, ident *ast.Ident, node ast.Node, qualifiedFieldName string)) TypeChecker {
 	return &typeChecker{
 		checkFunc: checkFunc,
 	}
 }
 
 type typeChecker struct {
-	checkFunc func(pass *analysis.Pass, ident *ast.Ident, node ast.Node, prefix string)
+	checkFunc func(pass *analysis.Pass, ident *ast.Ident, node ast.Node, qualifiedFieldName string)
 }
 
 // CheckNode checks the provided node for built-in types.