Skip to content

Commit 69ea78c

Browse files
authored
Refactor ParentWorkflow to use process instead of approve
1 parent d97b04a commit 69ea78c

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

docs/features/child-workflows.md

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ class ParentWorkflow extends Workflow
3737
{
3838
public function execute()
3939
{
40-
$childPromise = ChildWorkflowStub::make(ChildWorkflow::class);
40+
$child = ChildWorkflowStub::make(ChildWorkflow::class);
4141

4242
$childHandle = $this->child();
4343

44-
$childHandle->approve('approved');
44+
$childHandle->process('approved');
4545

46-
$result = yield $childPromise;
46+
$result = yield $child;
4747

4848
return $result;
4949
}
@@ -69,7 +69,7 @@ class ParentWorkflow extends Workflow
6969
$childHandles = $this->children();
7070

7171
foreach ($childHandles as $childHandle) {
72-
$childHandle->approve('approved');
72+
$childHandle->process('approved');
7373
}
7474

7575
$results = yield ChildWorkflowStub::all([$child1, $child2, $child3]);
@@ -93,29 +93,27 @@ use Workflow\WorkflowStub;
9393

9494
class ParentWorkflow extends Workflow
9595
{
96-
private bool $receivedApproval = false;
96+
private bool $processed = false;
9797
private ?string $approvalStatus = null;
9898

9999
#[SignalMethod]
100-
public function approve(string $status): void
100+
public function process(string $status): void
101101
{
102-
$this->receivedApproval = true;
102+
$this->processed = true;
103103
$this->approvalStatus = $status;
104104
}
105105

106106
public function execute()
107107
{
108-
$childPromise = ChildWorkflowStub::make(ChildWorkflow::class);
108+
$child = ChildWorkflowStub::make(ChildWorkflow::class);
109109

110110
$childHandle = $this->child();
111111

112-
yield WorkflowStub::await(fn () => $this->receivedApproval);
112+
yield WorkflowStub::await(fn () => $this->processed);
113113

114-
if ($childHandle && $this->approvalStatus) {
115-
$childHandle->processApproval($this->approvalStatus);
116-
}
114+
$childHandle->process($this->approvalStatus);
117115

118-
$result = yield $childPromise;
116+
$result = yield $child;
119117

120118
return $result;
121119
}

0 commit comments

Comments
 (0)