From 75f473c73b89d9b1b686366912a7e9afa68beace Mon Sep 17 00:00:00 2001 From: evoskuil Date: Sun, 28 Dec 2025 16:18:14 -0500 Subject: [PATCH 1/2] Fix method hiding warning. --- include/bitcoin/node/channels/channel_ws.hpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/bitcoin/node/channels/channel_ws.hpp b/include/bitcoin/node/channels/channel_ws.hpp index 64d6330c..88944b8c 100644 --- a/include/bitcoin/node/channels/channel_ws.hpp +++ b/include/bitcoin/node/channels/channel_ws.hpp @@ -55,9 +55,8 @@ class BCN_API channel_ws // TODO: Serialize message. const auto ptr = system::move_shared(std::move(message)); - network::count_handler complete = std::bind(&channel_ws::handle_send, - shared_from_base(), _1, _2, ptr, - std::move(handler)); + network::count_handler complete = std::bind(&channel_ws::handle_send_ws, + shared_from_base(), _1, _2, ptr, std::move(handler)); if (!ptr) { @@ -96,7 +95,7 @@ class BCN_API channel_ws }); } - inline void handle_send(const code& ec, size_t, const system::chunk_ptr&, + inline void handle_send_ws(const code& ec, size_t, const system::chunk_ptr&, const network::result_handler& handler) NOEXCEPT { if (ec) stop(ec); From 868271630c8ebee5ca0664eee4dc7e599c465463 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Sun, 28 Dec 2025 16:30:35 -0500 Subject: [PATCH 2/2] Add minimum_buffer/maximum_request settings for all services. --- src/parser.cpp | 95 +++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 90 insertions(+), 5 deletions(-) diff --git a/src/parser.cpp b/src/parser.cpp index 5eac0ec2..79321ddd 100644 --- a/src/parser.cpp +++ b/src/parser.cpp @@ -609,11 +609,6 @@ options_metadata parser::load_settings() THROWS value(&configured.network.maximum_skew_minutes), "The maximum allowable channel clock skew, defaults to '120'." ) - ( - "network.minimum_buffer", - value(&configured.network.minimum_buffer), - "The minimum retained read buffer size, defaults to '4000000'." - ) ( "network.rate_limit", value(&configured.network.rate_limit), @@ -666,6 +661,16 @@ options_metadata parser::load_settings() THROWS value(&configured.network.outbound.expiration_minutes), "The age limit for any connection, defaults to '60'." ) + ( + "outbound.minimum_buffer", + value(&configured.network.outbound.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "outbound.maximum_request", + value(&configured.network.outbound.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) ( "outbound.use_ipv6", value(&configured.network.outbound.use_ipv6), @@ -718,6 +723,16 @@ options_metadata parser::load_settings() THROWS value(&configured.network.inbound.expiration_minutes), "The age limit for any connection, defaults to '60'." ) + ( + "inbound.minimum_buffer", + value(&configured.network.inbound.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "inbound.maximum_request", + value(&configured.network.inbound.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) ( "inbound.enable_loopback", value(&configured.network.inbound.enable_loopback), @@ -755,6 +770,16 @@ options_metadata parser::load_settings() THROWS value(&configured.network.manual.expiration_minutes), "The age limit for any connection, defaults to '60' (will attempt reconnect)." ) + ( + "manual.minimum_buffer", + value(&configured.network.manual.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "manual.maximum_request", + value(&configured.network.manual.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) ( "manual.peer", value(&configured.network.manual.peers), @@ -787,6 +812,16 @@ options_metadata parser::load_settings() THROWS value(&configured.server.web.expiration_minutes), "The idle timeout (http keep-alive), defaults to '60'." ) + ( + "web.minimum_buffer", + value(&configured.server.web.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "web.maximum_request", + value(&configured.server.web.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) ( "web.server", value(&configured.server.web.server), @@ -844,6 +879,16 @@ options_metadata parser::load_settings() THROWS value(&configured.server.explore.expiration_minutes), "The idle timeout (http keep-alive), defaults to '60'." ) + ( + "explore.minimum_buffer", + value(&configured.server.explore.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "explore.maximum_request", + value(&configured.server.explore.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) ( "explore.server", value(&configured.server.explore.server), @@ -906,6 +951,16 @@ options_metadata parser::load_settings() THROWS value(&configured.server.bitcoind.expiration_minutes), "The idle timeout (http keep-alive), defaults to '60'." ) + ( + "bitcoind.minimum_buffer", + value(&configured.server.bitcoind.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "bitcoind.maximum_request", + value(&configured.server.bitcoind.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) ( "bitcoind.server", value(&configured.server.bitcoind.server), @@ -953,6 +1008,16 @@ options_metadata parser::load_settings() THROWS value(&configured.server.electrum.expiration_minutes), "The idle timeout (http keep-alive), defaults to '60'." ) + ( + "electrum.minimum_buffer", + value(&configured.server.electrum.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "electrum.maximum_request", + value(&configured.server.electrum.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) /* [stratum_v1] */ ////( @@ -980,6 +1045,16 @@ options_metadata parser::load_settings() THROWS value(&configured.server.stratum_v1.expiration_minutes), "The idle timeout (http keep-alive), defaults to '60'." ) + ( + "stratum_v1.minimum_buffer", + value(&configured.server.stratum_v1.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "stratum_v1.maximum_request", + value(&configured.server.stratum_v1.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) /* [stratum_v2] */ ////( @@ -1007,6 +1082,16 @@ options_metadata parser::load_settings() THROWS value(&configured.server.stratum_v2.expiration_minutes), "The idle timeout (http keep-alive), defaults to '60'." ) + ( + "stratum_v2.minimum_buffer", + value(&configured.server.stratum_v2.minimum_buffer), + "The minimum retained read buffer size, defaults to '4000000'." + ) + ( + "stratum_v2.maximum_request", + value(&configured.server.stratum_v2.maximum_request), + "The maximum allowed request size, defaults to '4000000'." + ) /* [node] */ (