Skip to content

feat: transport nim-v1.15#77

Open
rlve wants to merge 13 commits into
libp2p:masterfrom
rlve:transport-nim-libp2p
Open

feat: transport nim-v1.15#77
rlve wants to merge 13 commits into
libp2p:masterfrom
rlve:transport-nim-libp2p

Conversation

@rlve

@rlve rlve commented Mar 31, 2026

Copy link
Copy Markdown

Add nim-v1.15 to transport interop tests.

@rlve rlve marked this pull request as ready for review March 31, 2026 10:19
@rlve rlve requested a review from dhuseby as a code owner March 31, 2026 10:19
@richard-ramos richard-ramos self-requested a review March 31, 2026 13:08
@rlve

rlve commented Mar 31, 2026

Copy link
Copy Markdown
Author

Looks like nim is failing only against python ws:

  → Results:
    → Total: 55
    ✓ Passed: 52
    ✗ Failed: 3
    - python-v0.x x nim-v1.15 (ws, noise, mplex)

    - nim-v1.15 x python-v0.x (ws, noise, yamux)
    - nim-v1.15 x python-v0.x (ws, noise, mplex)
  → Total time: 00:08:20

  ✗ 3 test(s) failed

From what I observed the issue is that python sends observedAddr (protobuf field 4) as an empty bytes field (@[]) in its identify response. It's present in the protobuf but contains zero bytes, which causes nim to reject the message when it tries to parse empty MultiAddress.

cc: @richard-ramos

@rlve rlve changed the title add: transport nim-v1.15 feat: transport nim-v1.15 May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant