diff --git a/packages/browser/CHANGELOG.md b/packages/browser/CHANGELOG.md index dccd776..a7df9ed 100644 --- a/packages/browser/CHANGELOG.md +++ b/packages/browser/CHANGELOG.md @@ -1,5 +1,12 @@ # @lightpanda/browser +## 1.3.0 + +### Minor Changes + +- [#16](https://github.com/lightpanda-io/node-packages/pull/16) [`2d43701`](https://github.com/lightpanda-io/node-packages/commit/2d437016575d9322ffd58cc98d0c67a00177cee5) Thanks [@krichprollsch](https://github.com/krichprollsch)! - - prefer dash for binary options (#14) + - --timeout is deprecated (#16) + ## 1.2.0 ### Minor Changes diff --git a/packages/browser/package.json b/packages/browser/package.json index eba9bad..bee2c1d 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -1,6 +1,6 @@ { "name": "@lightpanda/browser", - "version": "1.2.0", + "version": "1.3.0", "description": "Lightpanda for Node.js", "main": "./dist/index.js", "module": "./dist/index.mjs", diff --git a/packages/browser/src/serve.ts b/packages/browser/src/serve.ts index e4b0019..3bb2e76 100644 --- a/packages/browser/src/serve.ts +++ b/packages/browser/src/serve.ts @@ -21,7 +21,6 @@ import { getExecutablePath, validatePort, validateUrl } from './utils.js' * @type {object} * @property {string} host - Host of the CDP server * @property {string} port - Port of the CDP server - * @property {number} timeout - Inactivity timeout in seconds before disconnecting clients * @property {boolean} disableHostVerification - Disables host verification on all HTTP requests * @property {boolean} obeyRobots - Fetches and obeys the robots.txt (if available) of the web pages we make requests towards. * @property {string} httpProxy - The HTTP proxy to use for all HTTP requests @@ -29,7 +28,6 @@ import { getExecutablePath, validatePort, validateUrl } from './utils.js' export type LightpandaServeOptions = { host?: string port?: number - timeout?: number disableHostVerification?: boolean obeyRobots?: boolean httpProxy?: string @@ -46,7 +44,7 @@ const defaultOptions: LightpandaServeOptions = { * @returns {Promise} */ export const serve = (options: LightpandaServeOptions = defaultOptions) => { - const { host, port, timeout, disableHostVerification, obeyRobots, httpProxy } = options + const { host, port, disableHostVerification, obeyRobots, httpProxy } = options if (port) { validatePort(port) @@ -60,7 +58,6 @@ export const serve = (options: LightpandaServeOptions = defaultOptions) => { const flags = [ { flag: '--host', value: host }, { flag: '--port', value: port }, - { flag: '--timeout', value: timeout }, { flag: '--insecure-disable-tls-host-verification', value: disableHostVerification,