fix: PnP saveChanges timing incorrect for AutoParent scenario

[AustinChangLinksys]

Summary

The PnP flow's buildSteps logic had incorrect saveChanges timing for the AutoParent scenario, and the flow control logic didn't properly handle AutoParent after saving.

Problem

In commit 436483bc (Release 1.2.12), when adding AutoParent support:

1. buildSteps saveChanges bug

// Bug: `? null : null` always returns null, WiFi steps never trigger saving
PersonalWiFiStep(saveChanges: !isGuestWiFiSupport && !isNightModeSupport ? null : null),
GuestWiFiStep(saveChanges: !isNightModeSupport ? null : null),
NightModeStep(saveChanges: null),
YourNetworkStep(saveChanges: _saveChanges),  // All saving delayed to here

2. Flow control used isUnconfigured instead of showYourNetwork

• _saveChanges whenComplete: AutoParent (isUnconfigured=false) skipped YourNetwork
• _showNeedReconnect: Same issue after WiFi reconnection
• onLastStep: Triggered duplicate saving for AutoParent

Fix

buildSteps

Align AutoParent with Unconfigured - save at last WiFi step before YourNetwork:

PersonalWiFiStep(saveChanges: !isGuestWiFiSupport && !isNightModeSupport ? _saveChanges : null),
GuestWiFiStep(saveChanges: !isNightModeSupport ? _saveChanges : null),
NightModeStep(saveChanges: _saveChanges),
YourNetworkStep(saveChanges: _confirmAddedNodes),

Flow control

Replace isUnconfigured with showYourNetwork (isUnconfigured || !isPrePaired) in:

• _saveChanges whenComplete
• _showNeedReconnect reconnect handler
• onLastStep condition

UI improvement

Wrap Auto Master connection error view with AppCard and maxWidth constraint for better readability.

Related

• https://github.com/linksys/LinksysWRT/issues/403

[AustinChangLinksys]

QA Verification

✅ Verified by QA in LinksysWRT#403

The fix has been tested and confirmed working for the AutoParent PnP flow.

[AustinChangLinksys]

@KarenChen-Linksys , Thanks for the help! These test result are quite helpful!

Auto Master vs PnP Race Condition - QA Test Results

Case	Precondition	Steps	Result	Status	Log	Screenshot
1	DUT is not connected to the internet source.	1. Open a browser and access the host IP. 2. Plug-in the WAN cable to the DUT. 3. Change WiFi settings then click the "Next" button. 4. Click the "Next" button on guest WiFi setting page. 5. Click the "Next" button Night mode setting page. 6. The "Saving changes" screen shows and then the "Reconnect to your router's WiFI to continue setup" page shows (auto-mastering...). 7. Connect to the new SSID and click the "Next" button. 8. Complete the PNP flow.	-	PASS	-	-
2	DUT is not connected to the internet source.	1. Open a browser and access the host IP. 2. Plug-in the WAN cable to the DUT. 3. Change WiFi settings then click the "Next" button. 4. Click the "Next" button on guest WiFi setting page. 5. Click the "Next" button Night mode setting page. 6. The "Saving changes" screen shows (auto-mastering...). 7. The "Reconnect to your router's WiFI to continue setup" page shows, connect to the new SSID and click the "Next" button. 8. Connect to the new SSID and click the "Next" button. 9. Complete the PNP flow.	-	PASS	-	-
3	-	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "Static IP" section. 4. Plug-in the WAN cable. 5. Fill in Static IP data and click the "Next" button (auto-mastering...). 6. After the auto-mastering is complete, click the "Next" again.	Step 5: It stays at the Static IP settings page and an error message "Couldn't establish a connection. Please check your info and try again." shows. Step 6: An error message "Incorrect password" shows.	FAIL	log_case 3.txt	screenshot
4	-	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "Static IP" section. 4. Fill in Static IP data and plug-in the WAN cable to the DUT. 5. Click the "Next" button (after a while it start auto-mastering...).	A spinner shows, after a while, the Static IP address settings shows again, and an error message "Incorrect password" appears.	FAIL	log_case 4.txt	screenshot
5	-	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "Static IP" section. 4. Fill in Static IP data and plug-in the WAN cable to the DUT. 5. Click the "Next" button. 6. After a while, it goes to the WiFi settings page. 7. Change WiFi settings then click the "Next" button. 8. Click the "Next" button on guest WiFi setting page. 9. Click the "Next" button Night mode setting page. 10. The "Saving changes" screen shows (auto-mastering...). 11. The "Reconnect to your router's WiFI to continue setup" page shows, connect to the new SSID and click the "Next" button. 12. Complete the PNP flow.	-	PASS	-	-
6	-	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "Static IP" section. 4. Fill in Static IP data and plug-in the WAN cable to the DUT. 5. Click the "Next" button. 6. After a while, it goes to the WiFi settings page. 7. Change WiFi settings then click the "Next" button. 8. Click the "Next" button on guest WiFi setting page. 9. Click the "Next" button Night mode setting page. 10. The "Saving changes" screen shows (auto-mastering...).	After a while, it will go to the "Reconnect to your router's WiFI to continue setup" page, but the SSID will remain unchanged.	FAIL	log_case 6.txt	-
7	-	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "Static IP" section. 4. Fill in Static IP data and plug-in the WAN cable to the DUT. 5. Click the "Next" button. 6. Spinner shows, after a while, it goes to the WiFi settings page. 7. Change WiFi settings then click the "Next" button. 8. Click the "Next" button on guest WiFi setting page. 9. Click the "Next" button Night mode setting page (auto-mastering...).	An unexpected error shows, and stuck on the page. (when this issue occurs, open another browser and access the host IP, it will then re-enter the paired PNP process)	FAIL	log_case 7.txt (happen twice)	screenshot
8	-	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "Static IP" section. 4. Fill in Static IP data and plug-in the WAN cable to the DUT. 5. Click the "Next" button. 6. Spinner shows, after a while, it goes to the WiFi settings page. 7. Keep default WiFi settings then click the "Next" button. 8. Click the "Next" button on guest WiFi setting page. 9. Click the "Next" button Night mode setting page. 10. The "Saving changes...." page shows (auto-mastering...). 11. After a while, the "Your network" page shows. 12. Complete the PNP flow.	-	PASS	-	-
9	DUT is connected to the PPPoE internet source.	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "PPPoE" section. 4. Fill in PPPoE data. 5. Click the "Next" button. 6. After a while, it goes to the WiFi settings page (auto-mastering...). 7. Change WiFi settings then click the "Next" button. 8. Click the "Next" button on guest WiFi setting page. 9. Click the "Next" button Night mode setting page.	After a while, it will go to the "Reconnect to your router's WiFI to continue setup" page, but the SSID will remain unchanged. (the result is the same as the case 6)	FAIL	-	-
10	DUT is connected to the PPPoE internet source.	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "PPPoE" section. 4. Fill in PPPoE data. 5. Click the "Next" button (auto-mastering...). 6. Click the "Next" button again.	Step 5: It stays at the Static IP settings page and an error message "Account name or password incorrect. Please try again." shows. Step 6: An error message "Incorrect password" shows.	FAIL	log_case 10.txt	screenshot
11	DUT is connected to the PPPoE internet source.	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "PPPoE" section. 4. Fill in PPPoE data. 5. Click the "Next" button (save changes and checking internet). 6. Then the WiFi settings page shows, change WiFi settings then click the "Next" button. 7. Click the "Next" button on guest WiFi setting page. 8. Click the "Next" button Night mode setting page (auto-mastering...). 9. Saving changes pages shows and the "Reconnect to your router's WiFI to continue setup" page shows. 10. Connect to the new SSID and click the "Next" button. 11. Complete the PNP flow.	-	PASS	-	-
12	DUT is connected to the PPPoE internet source.	1. Proceed PNP flow to the No internet connection page. 2. Select "Enter ISP settings" section. 3. Select "PPPoE" section. 4. Fill in PPPoE data. 5. Click the "Next" button. 6. After a while, it goes to the WiFi settings page. 7. Keep default WiFi settings then click the "Next" button. 8. Click the "Next" button on guest WiFi setting page. 9. Click the "Next" button Night mode setting page (auto-mastering...). 10. The "Saving changes" screen and then your network page shows. 11. Complete the PNP flow.	-	PASS	-	-

---

Summary: 6 PASS / 6 FAIL

Failure Pattern	Cases
"Incorrect password" error during auto-mastering	3, 4, 10
SSID unchanged after WiFi change	6, 9
Unexpected error / stuck	7

[AustinChangLinksys]

🔍 Automated investigation (preliminary triage)

Line: 1.x / JNAP
Root cause:

• UI defect (code logic error): Two separate bugs in the PnP AutoParent flow introduced in commit 436483bc (Release 1.2.12):

Evidence (from issue body — code path identified by author):

Bug 1 — buildSteps saveChanges always null for all Wi-Fi steps:

// Before fix — `? null : null` always evaluates to null:
PersonalWiFiStep(saveChanges: !isGuestWiFiSupport && !isNightModeSupport ? null : null),
GuestWiFiStep(saveChanges: !isNightModeSupport ? null : null),
NightModeStep(saveChanges: null),
YourNetworkStep(saveChanges: _saveChanges),  // All saving delayed to here

Result: AutoParent (isUnconfigured=false) skips YourNetworkStep → _saveChanges never called → settings not saved.

Bug 2 — Flow control uses isUnconfigured instead of showYourNetwork:

// _saveChanges whenComplete: AutoParent (isUnconfigured=false) skipped YourNetwork
// _showNeedReconnect: same issue after WiFi reconnection
// onLastStep: triggered duplicate saving for AutoParent

QA result (from Austin's comment 2026-07-07):

Summary: 6 PASS / 6 FAIL
Failure patterns:
- "Incorrect password" error during auto-mastering: Cases 3, 4, 10 (PPPoE/Static IP)
- SSID unchanged after WiFi change: Cases 6, 9 (DU/PPPoE)
- Unexpected error / stuck: Case 7

Note: The 6 failing cases involve PPPoE / DU ISP scenarios and may have an additional firmware-side component (cross-reference: linksys/LinksysWRT#403). The 6 passing cases confirm the core AutoParent flow fix works for standard scenarios.

Confidence: Medium — code-level root cause confirmed in issue body with explicit before/after snippets. QA 6P/6F indicates the core fix landed, but PPPoE/DU failures suggest possible additional layer (UI or firmware) yet to be isolated.

---

Auto-generated triage by Austin's tooling, pending Austin's review. Not a fix commitment.