From 5f5651ae5b9c8030d9442e36daa9e16f546fda42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C5=A1per=20Grom?= Date: Fri, 2 Oct 2026 08:38:58 +0100 Subject: [PATCH 1/3] fix: type the member module and its merge suggestion owners (CM-1535) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs linuxfoundation/lfx-cdp-insights-ops#235 Signed-off-by: Gašper Grom --- .../src/modules/lf/segments/store/actions.js | 1 + .../components/member-bot-suggestions.vue | 2 +- .../components/member-dropdown-content.vue | 6 +++++ .../components/member-merge-suggestions.vue | 23 ++++++++++--------- .../merge-suggestions-projects-filter.vue | 11 +++++---- .../member-merge-suggestions-details.vue | 20 ++++++++-------- .../modules/member/pages/member-list-page.vue | 2 +- .../modules/merge/types/MemberMessage.ts | 2 +- 8 files changed, 38 insertions(+), 29 deletions(-) diff --git a/frontend/src/modules/lf/segments/store/actions.js b/frontend/src/modules/lf/segments/store/actions.js index 8ea6af0936..370f284818 100644 --- a/frontend/src/modules/lf/segments/store/actions.js +++ b/frontend/src/modules/lf/segments/store/actions.js @@ -131,6 +131,7 @@ export default { }); }, // Projects + /** @param {{ parentSlug?: string | null, search?: string | null, offset?: number, limit?: number, reset?: boolean }} [params] */ listProjects({ parentSlug = null, search = null, offset, limit, reset = false, } = {}) { diff --git a/frontend/src/modules/member/components/member-bot-suggestions.vue b/frontend/src/modules/member/components/member-bot-suggestions.vue index 23c1e08b91..7342ef376b 100644 --- a/frontend/src/modules/member/components/member-bot-suggestions.vue +++ b/frontend/src/modules/member/components/member-bot-suggestions.vue @@ -124,7 +124,7 @@ const changed = ref(false); const suggestionQuery = () => (props.segments?.length ? { segments: props.segments } : {}); -const fetch = (page: number) => { +const fetch = (page: number): Promise => { if (page > -1) { currentOffset.value = page; } diff --git a/frontend/src/modules/member/components/member-dropdown-content.vue b/frontend/src/modules/member/components/member-dropdown-content.vue index 0efa8d91f0..3a1b6cdaef 100644 --- a/frontend/src/modules/member/components/member-dropdown-content.vue +++ b/frontend/src/modules/member/components/member-dropdown-content.vue @@ -169,6 +169,12 @@ import { useQueryClient } from '@tanstack/vue-query'; import { TanstackKey } from '@/shared/types/tanstack'; import type { Member } from '../types/Member'; +// shortcut: undefined HubspotApiService typed; the branch throws. revisit: HubSpot fix or removal (K-11) +declare const HubspotApiService: { + syncMember(id: string): Promise; + stopSyncMember(id: string): Promise; +}; + enum Actions { DELETE_CONTACT = 'deleteContact', SYNC_HUBSPOT = 'syncHubspot', diff --git a/frontend/src/modules/member/components/member-merge-suggestions.vue b/frontend/src/modules/member/components/member-merge-suggestions.vue index 44ac7c27bd..66791dae04 100644 --- a/frontend/src/modules/member/components/member-merge-suggestions.vue +++ b/frontend/src/modules/member/components/member-merge-suggestions.vue @@ -42,7 +42,7 @@ @@ -50,7 +50,7 @@ @@ -125,7 +125,7 @@ - - -