Commit 5adee37
committed
fix(release): declare workspace peerDeps + align adapter-vercel-ai post-rename
Bundle of F-PA7-CI-06 + F-PA7-CI-07 resolution. Both surfaced on the
ce811ae (version-bump) CI run; both block the 1.0.0-rc.0 release path.
F-PA7-CI-06 — workspace peerDeps declared via workspace:^ protocol
==================================================================
Four packages declared internal peerDeps using literal version ranges
(e.g. "@loop-engine/core": "^1.0.0-rc.0"). Before the version bump those
literals pointed at ^0.1.5, which resolved against the already-published
npm version and worked. After changeset version the literals pointed at
^1.0.0-rc.0 which is not yet published, so `pnpm install --frozen-lockfile`
failed in CI with ERR_PNPM_NO_MATCHING_VERSION (chicken-and-egg bootstrap:
can't install to build to publish).
Switching these specs to workspace:^ makes pnpm resolve against workspace
siblings locally; pnpm's publish-transform rewrites workspace:^ to the
actual ^X.Y.Z range at publish time, so the published artifact is
identical to what the literal range produced. Pure bootstrap-ergonomics
fix with zero consumer-visible change.
Edited peerDep specs:
- packages/adapter-pagerduty @loop-engine/core ^1.0.0-rc.0 -> workspace:^
- packages/adapter-perplexity @loop-engine/core ^1.0.0-rc.0 -> workspace:^
- packages/adapter-vercel-ai @loop-engine/core ^1.0.0-rc.0 -> workspace:^
- packages/runtime @loop-engine/events ^1.0.0-rc.0 -> workspace:^
F-PA7-CI-07 — adapter-vercel-ai aligned to post-SR-010 schema field names
=========================================================================
The workspace:^ conversion above unmasked pre-existing drift in
packages/adapter-vercel-ai/src/loop-tool-bridge.ts. That file referenced
pre-reconciliation field names (definition.loopId, transition.transitionId)
which were renamed to definition.id / transition.id during SR-004 + SR-010.
The pre-fix literal peerDep resolved @loop-engine/core against externally-
published 0.1.5 (which still carried the old field shape), so typecheck
falsely passed through all of Pass B against stale input types.
Five-token mechanical rename, identical in kind to SR-018's example-tree
alignment:
- definition.loopId -> definition.id (3 instances)
- transition.transitionId -> transition.id (3 instances — 2 wrapped in String())
No behavioral change, no signature change, no new imports. Engine API
keyword arguments (loopId:, transitionId:) in the call-site argument
positions stay unchanged — those are the engine's public input shape;
only the right-hand-side schema-field reads moved.
Scope verification
------------------
- `pnpm -r typecheck` clean across all 27 workspace projects (confirms
the drift is isolated to this one file; every other package already
typechecked against workspace types via workspace:* deps).
- `pnpm -r build` clean.
- `pnpm -r test` clean (no tests touch the edited lines).
- pnpm-lock.yaml regenerated; adapter-postgres (0.2.0) and adapter-kafka
(0.1.7) still on their separate version tracks.
Classification
--------------
F-PA7-CI-06: observation-tier C-15 instance (eighth; verification-gate
coverage widened on release-path exercise).
F-PA7-CI-07: substantive-tier C-15 *variant* (ninth; verification-against-
stale-inputs rather than verification-gap — the typecheck gate existed
but its input types were drifted. Distinct from prior C-15 instances.
SR-018's "example trees" framing should structurally have been "all
workspace files referencing reconciled field names" — to be logged as
a scope-derivation lesson for future reconciliation work).
Surface-Reconciliation-Id: SR-018 (completion) + SR-019 (release)1 parent ce811ae commit 5adee37
6 files changed
Lines changed: 15 additions & 34 deletions
File tree
- packages
- adapter-pagerduty
- adapter-perplexity
- adapter-vercel-ai
- src
- runtime
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments