Skip to content

Commit 0b03598

Browse files
author
lpb-docs
committed
fix(setup): memory subprocess thinking level from config, not hardcoded
llmThinkingOverride was stamped unconditionally ('low', now 'off') whenever a review model was chosen, clobbering any template/config value. It is a personal preference that must work with any model: template/existing config now wins, 'off' is only the built-in fallback (setdefault).
1 parent 886e583 commit 0b03598

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

scripts/localpibox/setup.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,10 @@
6666
"memoryCharLimit": 3000,
6767
"userCharLimit": 3000,
6868
"failureInjectionMaxEntries": 3,
69-
"llmThinkingOverride": "low",
69+
# Fallback only — the template/config value wins (setdefault below).
70+
# Subprocess LLM tasks (review/consolidation/flush) are mechanical;
71+
# thinking slows them down and risks long NPU occupation.
72+
"llmThinkingOverride": "off",
7073
}
7174

7275
_ABORT_TOKENS = ("q", "quit", "abort")
@@ -440,7 +443,7 @@ def configure_memory(agent_dir: str | Path, cons: Console, *,
440443
if not interactive:
441444
if default_model:
442445
base["llmModelOverride"] = default_model
443-
base["llmThinkingOverride"] = "low"
446+
base.setdefault("llmThinkingOverride", "off") # config/template wins
444447
try:
445448
agent_dir.mkdir(parents=True, exist_ok=True)
446449
out.write_text(json.dumps(base, indent=2) + "\n")
@@ -474,9 +477,11 @@ def configure_memory(agent_dir: str | Path, cons: Console, *,
474477
model = model or default_model
475478
if model:
476479
base["llmModelOverride"] = model
477-
base["llmThinkingOverride"] = "low"
478480
else:
479481
base.pop("llmModelOverride", None)
482+
# Thinking level is a personal preference — config/template wins;
483+
# "off" is only the fallback (works with any review model).
484+
base.setdefault("llmThinkingOverride", "off")
480485

481486
cons.info(" Context limits (press Enter for defaults):")
482487
base["memoryCharLimit"] = _ask_int(cons, "Memory entries", int(base.get("memoryCharLimit", 3000)))

scripts/test_localpibox_setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def test_wizard_noninteractive_success(tmpdir):
208208
assert settings["theme"] == "dark" # user key preserved
209209
mem = json.loads((agent / "lpb-memory-config.json").read_text())
210210
assert mem["llmModelOverride"] == "qwen3.5-9b-FLM"
211-
assert mem["llmThinkingOverride"] == "low"
211+
assert mem["llmThinkingOverride"] == "off"
212212
assert (agent / ".git").is_dir() # repo cloned by wizard
213213
print(" PASS\n")
214214

0 commit comments

Comments
 (0)