From bf9c41c39781de7e428e49e26b2ab2c26b90238f Mon Sep 17 00:00:00 2001
From: Kamil Skwarczynski <skwarczynskikamil@gmail.com>
Date: Wed, 4 Mar 2026 10:23:37 +0000
Subject: [PATCH] add CI to test if we can run without param handler

---
 CIValidations/SamplePDFValidations.cpp    | 8 +++++++-
 SamplesTutorial/SampleHandlerTutorial.cpp | 3 ++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/CIValidations/SamplePDFValidations.cpp b/CIValidations/SamplePDFValidations.cpp
index 2e260d2..14c0bd2 100755
--- a/CIValidations/SamplePDFValidations.cpp
+++ b/CIValidations/SamplePDFValidations.cpp
@@ -6,7 +6,7 @@ _MaCh3_Safe_Include_Start_ //{
 #include "Oscillator/OscillatorFactory.h"
 _MaCh3_Safe_Include_End_ //}
 
-void SharedNuOscTest(const std::string& config, ParameterHandlerGeneric* xsec){
+void SharedNuOscTest(const std::string& config, ParameterHandlerGeneric* xsec) {
   MACH3LOG_INFO("Utilising a shared NuOscillator object between all atmospheric samples");
 
   std::string OscillatorConfig = std::string(std::getenv("MaCh3Tutorial_ROOT")) + "/TutorialConfigs/NuOscillator/CUDAProb3.yaml";
@@ -25,6 +25,11 @@ void NoSplinesNoOscTest(const std::string& config){
   auto Sample = std::make_unique<SampleHandlerTutorial>(config, xsec.get());
 }
 
+void NoParamHandlerTest(const std::string& config) {
+  MACH3LOG_INFO("Starting {}", __func__);
+  auto Sample = std::make_unique<SampleHandlerTutorial>(config, nullptr);
+}
+
 void SampleLLHValidation(std::ostream& outFile, const std::string& OriginalSample, ParameterHandlerGeneric* xsec, const bool W2) {
   std::string NameTString = OriginalSample;
   xsec->SetParameters();
@@ -298,6 +303,7 @@ int main(int argc, char *argv[])
 
   SharedNuOscTest(SampleConfig.back(), xsec);
   NoSplinesNoOscTest(SampleConfig.back());
+  NoParamHandlerTest(SampleConfig.back());
 
   delete xsec;
 
diff --git a/SamplesTutorial/SampleHandlerTutorial.cpp b/SamplesTutorial/SampleHandlerTutorial.cpp
index 838d2df..42ef5b5 100755
--- a/SamplesTutorial/SampleHandlerTutorial.cpp
+++ b/SamplesTutorial/SampleHandlerTutorial.cpp
@@ -88,8 +88,9 @@ void SampleHandlerTutorial::ResetShifts(const int iEvent) {
 // ************************************************
 void SampleHandlerTutorial::SetupSplines() {
 // ************************************************
-  SplineHandler = nullptr;
+  if(ParHandler == nullptr) return;
 
+  SplineHandler = nullptr;
   if(ParHandler->GetNumParamsFromSampleName(GetName(), SystType::kSpline) > 0){
     SplineHandler = std::make_unique<BinnedSplineTutorial>(ParHandler, Modes.get());
     InitialiseSplineObject();