add async no threading flag#54
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the asynchronous execution model by introducing a new debug flag, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a useful ASYNC_NO_THREADING debug flag and centralizes the logic for offloading blocking calls into a run_in_io_executor helper. The refactoring across the different files to use this new helper is clean and improves consistency. I've found one potential issue with how the environment variable is checked, which could lead to unexpected behavior. My feedback is focused on making this check more robust.
|
|
||
|
|
||
| async def run_in_io_executor(func, /, *args, **kwargs): | ||
| if os.environ.get("ASYNC_NO_THREADING"): |
There was a problem hiding this comment.
The current check for ASYNC_NO_THREADING is truthy for any non-empty string. This means if a user sets ASYNC_NO_THREADING=0 or ASYNC_NO_THREADING=false expecting to disable this debug mode, it will actually be enabled because "0" and "false" are truthy as strings. This can be misleading.
To make the behavior more explicit and align with common conventions for boolean flags in environment variables, it's better to check for a specific value like "1". The documentation already instructs users to set it to 1.
| if os.environ.get("ASYNC_NO_THREADING"): | |
| if os.environ.get("ASYNC_NO_THREADING") == "1": |
…un-motion-trim-local
Summary
ASYNC_NO_THREADINGdebug flag for pipeline blocking offloadsTesting
uv run ruff check src/refiner/execution/asyncio/runtime.py docs/local-execution.md src/refiner/pipeline/sinks/lerobot/_lerobot_video_writer.py src/refiner/pipeline/utils/cache/decoder_cache.py src/refiner/pipeline/utils/cache/file_cache.pyimport os, asyncio
from refiner.execution.asyncio.runtime import run_in_io_executor
async def main():
os.environ["ASYNC_NO_THREADING"] = "1"
value = await run_in_io_executor(lambda: "ok")
print(value)
asyncio.run(main())
PY`