Skip to content

add async no threading flag#54

Open
Hynek Kydlíček (hynky1999) wants to merge 2 commits into
mainfrom
codex/run-motion-trim-local
Open

add async no threading flag#54
Hynek Kydlíček (hynky1999) wants to merge 2 commits into
mainfrom
codex/run-motion-trim-local

Conversation

@hynky1999
Copy link
Copy Markdown
Collaborator

Summary

  • add an ASYNC_NO_THREADING debug flag for pipeline blocking offloads
  • route video commit, decoder cache opens, and media cache downloads through one helper
  • document how to run the flag locally

Testing

  • uv run ruff check src/refiner/execution/asyncio/runtime.py docs/local-execution.md src/refiner/pipeline/sinks/lerobot/_lerobot_video_writer.py src/refiner/pipeline/utils/cache/decoder_cache.py src/refiner/pipeline/utils/cache/file_cache.py
  • `uv run python - <<'PY'
    import os, asyncio
    from refiner.execution.asyncio.runtime import run_in_io_executor

async def main():
os.environ["ASYNC_NO_THREADING"] = "1"
value = await run_in_io_executor(lambda: "ok")
print(value)

asyncio.run(main())
PY`

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the asynchronous execution model by introducing a new debug flag, ASYNC_NO_THREADING. This flag allows developers to bypass threadpool offloads for specific blocking I/O operations, enabling easier debugging of async code. The change also centralizes the execution of these operations through a new helper function, run_in_io_executor, improving consistency and maintainability across various pipeline components.

Highlights

  • New Debug Flag: Introduced ASYNC_NO_THREADING environment variable to disable threadpool offloads for blocking I/O operations, forcing them to run inline on the async runtime thread.
  • Centralized Async Execution: Consolidated video commit, decoder cache opens, and media cache downloads to use a new run_in_io_executor helper.
  • Documentation: Added documentation for the ASYNC_NO_THREADING flag, explaining its purpose and how to use it for local debugging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment Gemini (@gemini-code-assist) Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a useful ASYNC_NO_THREADING debug flag and centralizes the logic for offloading blocking calls into a run_in_io_executor helper. The refactoring across the different files to use this new helper is clean and improves consistency. I've found one potential issue with how the environment variable is checked, which could lead to unexpected behavior. My feedback is focused on making this check more robust.



async def run_in_io_executor(func, /, *args, **kwargs):
if os.environ.get("ASYNC_NO_THREADING"):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current check for ASYNC_NO_THREADING is truthy for any non-empty string. This means if a user sets ASYNC_NO_THREADING=0 or ASYNC_NO_THREADING=false expecting to disable this debug mode, it will actually be enabled because "0" and "false" are truthy as strings. This can be misleading.

To make the behavior more explicit and align with common conventions for boolean flags in environment variables, it's better to check for a specific value like "1". The documentation already instructs users to set it to 1.

Suggested change
if os.environ.get("ASYNC_NO_THREADING"):
if os.environ.get("ASYNC_NO_THREADING") == "1":

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant