AC-676: Create phpcs static check for ObsoleteConnectionTest

eliseacornejo · eliseacornejo · commit 5a34fd1e0a4f · 2021-10-07T11:00:57.000+02:00
diff --git a/Magento2/Tests/Legacy/ObsoleteConnectionUnitTest.php b/Magento2/Tests/Legacy/ObsoleteConnectionUnitTest.php
@@ -23,14 +23,14 @@ public function getErrorList()
     public function getWarningList()
     {
         return [
-            3 => 1,
-            6 => 1,
+            7 => 1,
             10 => 1,
             14 => 1,
             18 => 1,
-            21 => 1,
+            22 => 1,
             25 => 1,
-            32 => 1
+            29 => 1,
+            36 => 1
         ];
     }
 }
diff --git a/Magento2/ruleset.xml b/Magento2/ruleset.xml
@@ -313,6 +313,10 @@
         <severity>8</severity>
         <type>warning</type>
     </rule>
+    <rule ref="Magento2.Legacy.ObsoleteConnection">
+        <severity>8</severity>
+        <type>warning</type>
+    </rule>
 
     <!-- Severity 7 warnings: General code issues. -->
     <rule ref="Generic.Arrays.DisallowLongArraySyntax">

Original file line number	Diff line number	Diff line change
`@@ -23,14 +23,14 @@ public function getErrorList()`
`23`	`23`	`public function getWarningList()`
`24`	`24`	`{`
`25`	`25`	`return [`
`26`		`- 3 => 1,`
`27`		`- 6 => 1,`
	`26`	`+ 7 => 1,`
`28`	`27`	`10 => 1,`
`29`	`28`	`14 => 1,`
`30`	`29`	`18 => 1,`
`31`		`- 21 => 1,`
	`30`	`+ 22 => 1,`
`32`	`31`	`25 => 1,`
`33`		`- 32 => 1`
	`32`	`+ 29 => 1,`
	`33`	`+ 36 => 1`
`34`	`34`	`];`
`35`	`35`	`}`
`36`	`36`	`}`