CE#34653: Added fixes after code review

Author: andrewbess

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php

@@ -569,7 +569,7 @@ private function getAttributeValue($attributeId, $valueIds, $storeId)
         if (false !== $value) {
             $optionValue = $this->getAttributeOptionValue($attributeId, $valueIds, $storeId);
             if (null === $optionValue) {
-                $value = $value !== null ? $this->filterAttributeValue($value) : '';
+                $value = $this->filterAttributeValue($value);
             } else {
                 $value = implode($this->separator, array_filter([$value, $optionValue]));
             }
@@ -605,7 +605,7 @@ private function getAttributeOptionValue($attributeId, $valueIds, $storeId)
                 $this->attributeOptions[$optionKey] = array_column($options, 'label', 'value');
                 $this->attributeOptions[$optionKey] = array_map(
                     function ($value) {
-                        return $value !== null ? $this->filterAttributeValue($value) : '';
+                        return $this->filterAttributeValue($value);
                     },
                     $this->attributeOptions[$optionKey]
                 );
@@ -625,11 +625,11 @@ function ($value) {
     /**
      * Remove whitespaces and tags from attribute value
      *
-     * @param string $value
+     * @param string|null $value
      * @return string
      */
-    private function filterAttributeValue(string $value)
+    private function filterAttributeValue(?string $value)
     {
-        return preg_replace('/\s+/iu', ' ', trim(strip_tags($value)));
+        return $value !== null ? preg_replace('/\s+/iu', ' ', trim(strip_tags($value))) : '';
     }
 }

app/code/Magento/Quote/Model/Quote/Address.php

@@ -1452,10 +1452,8 @@ public function setCountryId($countryId)
      */
     public function getStreet()
     {
-        $street = $this->getData(self::KEY_STREET);
-        if ($street === null) {
-            return [''];
-        }
+        $street = $this->getData(self::KEY_STREET) ?? [''];
+
         return is_array($street) ? $street : explode("\n", $street);
     }