ACPT-1709: Clean up skip-list for GraphQlState Test

 -- fix test failures

Author: andimov

app/code/Magento/ConfigurableProductGraphQl/Test/Unit/Model/Cart/BuyRequest/SuperAttributeDataProviderTest.php

@@ -24,6 +24,8 @@
 
 /**
  * Test for SuperAttributeDataProvider
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class SuperAttributeDataProviderTest extends TestCase
 {

app/code/Magento/Customer/Model/Address.php

@@ -388,6 +388,7 @@ protected function getCustomAttributesCodes()
      *
      * @return \Magento\Customer\Model\Address\CustomAttributeListInterface
      * @deprecated 100.0.6
+     * @see not recommended way
      */
     private function getAttributeList()
     {

app/code/Magento/Customer/Model/Address/AbstractAddress.php

@@ -35,6 +35,7 @@
  * @method bool getShouldIgnoreValidation()
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
+ * @SuppressWarnings(PHPMD.TooManyFields)
  *
  * @api
  * @since 100.0.2
@@ -71,7 +72,10 @@ class AbstractAddress extends AbstractExtensibleModel implements AddressModelInt
      */
     protected static $_countryModels = [];
 
-    /** @var CountryModelsCache */
+    /**
+     * @var CountryModelsCache
+     * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
+     */
     private readonly CountryModelsCache $countryModelsCache;
 
     /**
@@ -83,7 +87,10 @@ class AbstractAddress extends AbstractExtensibleModel implements AddressModelInt
      */
     protected static $_regionModels = [];
 
-    /** @var RegionModelsCache */
+    /**
+     * @var RegionModelsCache
+     * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
+     */
     private readonly RegionModelsCache $regionModelsCache;
 
     /**
@@ -156,7 +163,7 @@ class AbstractAddress extends AbstractExtensibleModel implements AddressModelInt
      * @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource
      * @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
      * @param array $data
-     * @param CompositeValidator|null $compositeValidator
+     * @param CompositeValidator $compositeValidator
      * @param CountryModelsCache|null $countryModelsCache
      * @param RegionModelsCache|null $regionModelsCache
      *
@@ -179,7 +186,7 @@ public function __construct(
         \Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
         \Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
         array $data = [],
-        ?CompositeValidator $compositeValidator = null,
+        CompositeValidator $compositeValidator = null,
         ?CountryModelsCache $countryModelsCache = null,
         ?RegionModelsCache $regionModelsCache = null,
     ) {

app/code/Magento/Customer/Model/Address/AbstractAddress/CountryModelsCache.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Customer\Model\Address\AbstractAddress;
 
@@ -29,7 +30,7 @@ public function _resetState(): void
      * Adds model to cache using key
      *
      * @param string $key
-     * @param Country $value
+     * @param Country $model
      * @return void
      */
     public function add(string $key, Country $model) : void

app/code/Magento/Customer/Model/Address/AbstractAddress/RegionModelsCache.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Customer\Model\Address\AbstractAddress;
 
@@ -29,7 +30,7 @@ public function _resetState(): void
      * Adds model to cache using key
      *
      * @param string $key
-     * @param Region $value
+     * @param Region $model
      * @return void
      */
     public function add(string $key, Region $model) : void

lib/internal/Magento/Framework/Logger/LoggerProxy.php

@@ -21,6 +21,7 @@ class LoggerProxy implements LoggerInterface, NoninterceptableInterface, ResetAf
 {
     /**
      * @var ObjectManagerInterface
+     * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
      */
     private readonly ObjectManagerInterface $objectManager;
 

lib/internal/Magento/Framework/MessageQueue/Topology/Config/Xml/Converter.php

@@ -65,7 +65,7 @@ public function __construct(
     /**
      * @inheritdoc
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
-     * phpcs:ignore Magento2.Performance.ForeachArrayMerge
+     * phpcs:disable Magento2.Performance.ForeachArrayMerge
      */
     public function convert($source)
     {

lib/internal/Magento/Framework/ObjectManager/Resetter/Resetter.php

@@ -13,7 +13,6 @@
 use Magento\Framework\ObjectManager\ResetAfterRequestInterface;
 use Magento\Framework\ObjectManagerInterface;
 use WeakMap;
-use WeakReference;
 
 /**
  * Class that keeps track of the instances that need to be reset, and resets them
@@ -32,7 +31,6 @@ class Resetter implements ResetterInterface
     /** @var WeakMapSorter|null Note: We use temporal coupling here because of chicken/egg during bootstrapping */
     private ?WeakMapSorter $weakMapSorter = null;
 
-
     /**
      * @var array
      */
@@ -41,6 +39,8 @@ class Resetter implements ResetterInterface
     /**
      * Constructor
      *
+     * @param ComponentRegistrarInterface $componentRegistrar
+     * @param array $classList
      * @return void
      * @phpcs:disable Magento2.Functions.DiscouragedFunction
      */
@@ -71,7 +71,6 @@ private function getPaths(): \Generator
         }
     }
 
-
     /**
      * Add instance to be reset later
      *

lib/internal/Magento/Framework/ObjectManager/Resetter/ResetterFactory.php

@@ -19,6 +19,9 @@ class ResetterFactory
      */
     private static string $resetterClassName = Resetter::class;
 
+    /**
+     * @param ObjectManagerInterface $objectManager
+     */
     public function __construct(private ObjectManagerInterface $objectManager)
     {
     }

lib/internal/Magento/Framework/TestFramework/ApplicationStateComparator/Resetter.php

@@ -9,7 +9,6 @@
 
 use Magento\Framework\Component\ComponentRegistrarInterface;
 use Magento\Framework\ObjectManager\Resetter\Resetter as OriginalResetter;
-use Magento\Framework\ObjectManager\Resetter\WeakMapSorter;
 use Magento\Framework\ObjectManagerInterface;
 use WeakMap;
 
@@ -35,6 +34,8 @@ class Resetter extends OriginalResetter
     /**
      * Constructor
      *
+     * @param ComponentRegistrarInterface $componentRegistrar
+     * @param array $classList
      * @return void
      */
     public function __construct(ComponentRegistrarInterface $componentRegistrar, array $classList = [])