Skip to content

Commit 20973b5

Browse files
committed
Fixed static test failrues
1 parent 3fddfe4 commit 20973b5

File tree

8 files changed

+28
-31
lines changed

8 files changed

+28
-31
lines changed

app/code/Magento/SalesRule/Model/System/Config/Source/Coupon/Format.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
class Format implements \Magento\Framework\Option\ArrayInterface
1212
{
1313
/**
14-
* Sales rule coupon
15-
*
1614
* @var \Magento\SalesRule\Helper\Coupon
1715
*/
1816
protected $_salesRuleCoupon = null;
@@ -26,7 +24,7 @@ public function __construct(\Magento\SalesRule\Helper\Coupon $salesRuleCoupon)
2624
}
2725

2826
/**
29-
* {@inheritdoc}
27+
* @inheritdoc
3028
*/
3129
public function toOptionArray()
3230
{

app/code/Magento/SendFriend/Block/Send.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,11 @@
1717
class Send extends \Magento\Framework\View\Element\Template
1818
{
1919
/**
20-
* SendFriend data
21-
*
2220
* @var \Magento\SendFriend\Helper\Data
2321
*/
2422
protected $_sendfriendData = null;
2523

2624
/**
27-
* Core registry
28-
*
2925
* @var \Magento\Framework\Registry
3026
*/
3127
protected $_coreRegistry = null;
@@ -227,6 +223,7 @@ public function canSend()
227223

228224
/**
229225
* @inheritdoc
226+
* @return void
230227
* @since 100.3.1
231228
*/
232229
protected function _prepareLayout()

app/code/Magento/SendFriend/Helper/Data.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,23 @@
1414
*/
1515
class Data extends \Magento\Framework\App\Helper\AbstractHelper
1616
{
17-
const XML_PATH_ENABLED = 'sendfriend/email/enabled';
17+
public const XML_PATH_ENABLED = 'sendfriend/email/enabled';
1818

19-
const XML_PATH_ALLOW_FOR_GUEST = 'sendfriend/email/allow_guest';
19+
public const XML_PATH_ALLOW_FOR_GUEST = 'sendfriend/email/allow_guest';
2020

21-
const XML_PATH_MAX_RECIPIENTS = 'sendfriend/email/max_recipients';
21+
public const XML_PATH_MAX_RECIPIENTS = 'sendfriend/email/max_recipients';
2222

23-
const XML_PATH_MAX_PER_HOUR = 'sendfriend/email/max_per_hour';
23+
public const XML_PATH_MAX_PER_HOUR = 'sendfriend/email/max_per_hour';
2424

25-
const XML_PATH_LIMIT_BY = 'sendfriend/email/check_by';
25+
public const XML_PATH_LIMIT_BY = 'sendfriend/email/check_by';
2626

27-
const XML_PATH_EMAIL_TEMPLATE = 'sendfriend/email/template';
27+
public const XML_PATH_EMAIL_TEMPLATE = 'sendfriend/email/template';
2828

29-
const COOKIE_NAME = 'stf';
29+
public const COOKIE_NAME = 'stf';
3030

31-
const CHECK_IP = 1;
31+
public const CHECK_IP = 1;
3232

33-
const CHECK_COOKIE = 0;
33+
public const CHECK_COOKIE = 0;
3434

3535
/**
3636
* Check is enabled Module

app/code/Magento/Shipping/Block/Adminhtml/View.php

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
class View extends \Magento\Backend\Block\Widget\Form\Container
1515
{
1616
/**
17-
* Core registry
18-
*
1917
* @var \Magento\Framework\Registry
2018
*/
2119
protected $_coreRegistry = null;
@@ -35,6 +33,8 @@ public function __construct(
3533
}
3634

3735
/**
36+
* Initialize View
37+
*
3838
* @return void
3939
*/
4040
protected function _construct()
@@ -84,6 +84,8 @@ public function getShipment()
8484
}
8585

8686
/**
87+
* Header Text get
88+
*
8789
* @return \Magento\Framework\Phrase
8890
*/
8991
public function getHeaderText()
@@ -106,6 +108,8 @@ public function getHeaderText()
106108
}
107109

108110
/**
111+
* Get URL
112+
*
109113
* @return string
110114
*/
111115
public function getBackUrl()
@@ -120,6 +124,8 @@ public function getBackUrl()
120124
}
121125

122126
/**
127+
* Get Email Url
128+
*
123129
* @return string
124130
*/
125131
public function getEmailUrl()
@@ -128,6 +134,8 @@ public function getEmailUrl()
128134
}
129135

130136
/**
137+
* Get Print Url
138+
*
131139
* @return string
132140
*/
133141
public function getPrintUrl()
@@ -136,6 +144,8 @@ public function getPrintUrl()
136144
}
137145

138146
/**
147+
* Update back button url
148+
*
139149
* @param bool $flag
140150
* @return $this
141151
*/

app/code/Magento/Shipping/Block/Adminhtml/View/Comments.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
class Comments extends \Magento\Backend\Block\Text\ListText
1717
{
1818
/**
19-
* Core registry
20-
*
2119
* @var \Magento\Framework\Registry
2220
*/
2321
protected $_coreRegistry = null;

app/code/Magento/Shipping/Block/Items.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
class Items extends \Magento\Sales\Block\Items\AbstractItems
1919
{
2020
/**
21-
* Core registry
22-
*
2321
* @var \Magento\Framework\Registry
2422
*/
2523
protected $_coreRegistry = null;

app/code/Magento/Sitemap/Block/Adminhtml/Edit.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
class Edit extends \Magento\Backend\Block\Widget\Form\Container
1212
{
1313
/**
14-
* Core registry
15-
*
1614
* @var \Magento\Framework\Registry
1715
*/
1816
protected $_coreRegistry = null;

app/code/Magento/Sitemap/Model/Observer.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,33 +22,31 @@ class Observer
2222
/**
2323
* Enable/disable configuration
2424
*/
25-
const XML_PATH_GENERATION_ENABLED = 'sitemap/generate/enabled';
25+
public const XML_PATH_GENERATION_ENABLED = 'sitemap/generate/enabled';
2626

2727
/**
2828
* Cronjob expression configuration
2929
*
3030
* @deprecated Use \Magento\Cron\Model\Config\Backend\Sitemap::CRON_STRING_PATH instead.
3131
*/
32-
const XML_PATH_CRON_EXPR = 'crontab/default/jobs/generate_sitemaps/schedule/cron_expr';
32+
public const XML_PATH_CRON_EXPR = 'crontab/default/jobs/generate_sitemaps/schedule/cron_expr';
3333

3434
/**
3535
* Error email template configuration
3636
*/
37-
const XML_PATH_ERROR_TEMPLATE = 'sitemap/generate/error_email_template';
37+
public const XML_PATH_ERROR_TEMPLATE = 'sitemap/generate/error_email_template';
3838

3939
/**
4040
* Error email identity configuration
4141
*/
42-
const XML_PATH_ERROR_IDENTITY = 'sitemap/generate/error_email_identity';
42+
public const XML_PATH_ERROR_IDENTITY = 'sitemap/generate/error_email_identity';
4343

4444
/**
4545
* 'Send error emails to' configuration
4646
*/
47-
const XML_PATH_ERROR_RECIPIENT = 'sitemap/generate/error_email';
47+
public const XML_PATH_ERROR_RECIPIENT = 'sitemap/generate/error_email';
4848

4949
/**
50-
* Core store config
51-
*
5250
* @var \Magento\Framework\App\Config\ScopeConfigInterface
5351
*/
5452
private $scopeConfig;

0 commit comments

Comments
 (0)