AC:11798::Shipping price showing diffrent in printed pdf

Author: Pooja.Manral

app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php

@@ -158,11 +158,11 @@ abstract public function getPdf();
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
      * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
      * @param \Magento\Sales\Model\Order\Address\Renderer $addressRenderer
-     * @param TaxHelper $taxHelper
      * @param array $data
      * @param Database $fileStorageDatabase
      * @param RtlTextHandler|null $rtlTextHandler
      * @param Image $image
+     * @param TaxHelper $taxHelper
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -181,7 +181,6 @@ public function __construct(
         ?RtlTextHandler $rtlTextHandler = null,
         ?Image $image = null,
         ?TaxHelper $taxHelper = null
-
     ) {
         $this->addressRenderer = $addressRenderer;
         $this->_paymentData = $paymentData;

app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php

@@ -8,9 +8,6 @@
 
 namespace Magento\Sales\Model\Order\Pdf;
 
-use Magento\Framework\App\ObjectManager;
-use Magento\Tax\Helper\Data as TaxHelper;
-
 /**
  * Sales Order Creditmemo PDF model
  *
@@ -39,7 +36,6 @@ class Creditmemo extends AbstractPdf
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
      * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
      * @param \Magento\Sales\Model\Order\Address\Renderer $addressRenderer
-     * @param \Magento\Tax\Helper\Data $taxHelper
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Store\Model\App\Emulation|null $appEmulation
      * @param array $data
@@ -58,14 +54,12 @@ public function __construct(
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
         \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,
         \Magento\Sales\Model\Order\Address\Renderer $addressRenderer,
-        TaxHelper $taxHelper = null,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\Store\Model\App\Emulation $appEmulation,
         array $data = []
     ) {
         $this->_storeManager = $storeManager;
         $this->appEmulation = $appEmulation;
-        $this->taxHelper = $taxHelper ?: ObjectManager::getInstance()->get(TaxHelper::class);
         parent::__construct(
             $paymentData,
             $string,

app/code/Magento/Sales/Model/Order/Pdf/Invoice.php

@@ -6,8 +6,6 @@
 namespace Magento\Sales\Model\Order\Pdf;
 
 use Magento\Sales\Model\ResourceModel\Order\Invoice\Collection;
-use Magento\Framework\App\ObjectManager;
-use Magento\Tax\Helper\Data as TaxHelper;
 
 /**
  * Sales Order Invoice PDF model
@@ -36,7 +34,6 @@ class Invoice extends AbstractPdf
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
      * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
      * @param \Magento\Sales\Model\Order\Address\Renderer $addressRenderer
-     * @param \Magento\Tax\Helper\Data $taxHelper
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Store\Model\App\Emulation $appEmulation
      * @param array $data
@@ -54,14 +51,12 @@ public function __construct(
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
         \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,
         \Magento\Sales\Model\Order\Address\Renderer $addressRenderer,
-        TaxHelper $taxHelper = null,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\Store\Model\App\Emulation $appEmulation,
         array $data = []
     ) {
         $this->_storeManager = $storeManager;
         $this->appEmulation = $appEmulation;
-        $this->taxHelper = $taxHelper ?: ObjectManager::getInstance()->get(TaxHelper::class);
         parent::__construct(
             $paymentData,
             $string,

app/code/Magento/Sales/Model/Order/Pdf/Shipment.php

@@ -5,9 +5,6 @@
  */
 namespace Magento\Sales\Model\Order\Pdf;
 
-use Magento\Framework\App\ObjectManager;
-use Magento\Tax\Helper\Data as TaxHelper;
-
 /**
  * Sales Order Shipment PDF model
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -35,7 +32,6 @@ class Shipment extends AbstractPdf
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
      * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
      * @param \Magento\Sales\Model\Order\Address\Renderer $addressRenderer
-     * @param \Magento\Tax\Helper\Data $taxHelper
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Store\Model\App\Emulation $appEmulation
      * @param array $data
@@ -53,14 +49,12 @@ public function __construct(
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
         \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,
         \Magento\Sales\Model\Order\Address\Renderer $addressRenderer,
-        TaxHelper $taxHelper = null,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\Store\Model\App\Emulation $appEmulation,
         array $data = []
     ) {
         $this->_storeManager = $storeManager;
         $this->appEmulation = $appEmulation;
-        $this->taxHelper = $taxHelper ?: ObjectManager::getInstance()->get(TaxHelper::class);
         parent::__construct(
             $paymentData,
             $string,

app/code/Magento/Shipping/Model/Order/Pdf/Packaging.php

@@ -6,8 +6,6 @@
 namespace Magento\Shipping\Model\Order\Pdf;
 
 use Magento\Shipping\Helper\Carrier;
-use Magento\Framework\App\ObjectManager;
-use Magento\Tax\Helper\Data as TaxHelper;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -45,7 +43,6 @@ class Packaging extends \Magento\Sales\Model\Order\Pdf\AbstractPdf
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
      * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
      * @param \Magento\Sales\Model\Order\Address\Renderer $addressRenderer
-     * @param \Magento\Tax\Helper\Data $taxHelper
      * @param Carrier $carrierHelper
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Framework\View\LayoutInterface $layout
@@ -65,7 +62,6 @@ public function __construct(
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
         \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,
         \Magento\Sales\Model\Order\Address\Renderer $addressRenderer,
-        TaxHelper $taxHelper = null,
         Carrier $carrierHelper,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\Framework\View\LayoutInterface $layout,
@@ -76,7 +72,6 @@ public function __construct(
         $this->_storeManager = $storeManager;
         $this->_layout = $layout;
         $this->_localeResolver = $localeResolver;
-        $this->taxHelper = $taxHelper ?: ObjectManager::getInstance()->get(TaxHelper::class);
 
         parent::__construct(
             $paymentData,