ACP2E-2673: Price partial indexing performance

- added indexes for temporary indexer database table
- temporary indexer table is now being dropped instead of deleting data

Author: aplapana

app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php

@@ -408,11 +408,11 @@ function ($type) use ($productsTypes) {
                 foreach ($this->dimensionCollectionFactory->create() as $dimensions) {
                     $this->tableMaintainer->createMainTmpTable($dimensions);
                     $temporaryTable = $this->tableMaintainer->getMainTmpTable($dimensions);
-                    $this->_emptyTable($temporaryTable);
                     $indexer->executeByDimensions($dimensions, \SplFixedArray::fromArray($entityIds, false));
                     $mainTable = $this->tableMaintainer->getMainTableByDimensions($dimensions);
                     $this->_insertFromTable($temporaryTable, $mainTable);
                     $this->deleteOutdatedData($entityIds, $temporaryTable, $mainTable);
+                    $this->_connection->dropTable($temporaryTable);
                 }
             } else {
                 // handle 3d-party indexers for backward compatibility
@@ -437,18 +437,12 @@ function ($type) use ($productsTypes) {
      */
     private function deleteOutdatedData(array $entityIds, string $temporaryTable, string $mainTable): void
     {
-        $connection = $this->getConnection();
-        $describe = $connection->describeTable($connection->getTableName($temporaryTable));
-        if (false === $describe['entity_id']['NULLABLE']) {
-            return;
-        }
-
         $joinCondition = [
             'tmp_table.entity_id = main_table.entity_id',
             'tmp_table.customer_group_id = main_table.customer_group_id',
             'tmp_table.website_id = main_table.website_id',
         ];
-        $select = $connection->select()
+        $select = $this->getConnection()->select()
             ->from(['main_table' => $mainTable], null)
             ->joinLeft(['tmp_table' => $temporaryTable], implode(' AND ', $joinCondition), null)
             ->where('tmp_table.entity_id IS NULL')

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/Action/RowsTest.php

@@ -143,7 +143,8 @@ public function testBatchProcessing()
         $select->method('join')->willReturnSelf();
         $adapter = $this->createMock(AdapterInterface::class);
         $adapter->method('select')->willReturn($select);
-        $adapter->method('describeTable')->willReturn(['entity_id' => ['NULLABLE' => true]]);
+        $adapter->method('describeTable')->willReturn([]);
+        $adapter->expects($this->exactly(4))->method('dropTable');
         $this->defaultIndexerResource->method('getConnection')->willReturn($adapter);
         $adapter->method('fetchAll')->with($select)->willReturn([]);
 
@@ -193,7 +194,21 @@ public function testBatchProcessing()
             ->method('getPrimaryKeyName')
             ->willReturn('entity_id');
 
-        $this->actionRows->execute($ids);
+        $actionRows = new Rows(
+            $this->config,
+            $this->storeManager,
+            $this->currencyFactory,
+            $this->localeDate,
+            $this->dateTime,
+            $this->catalogProductType,
+            $this->indexerPriceFactory,
+            $this->defaultIndexerResource,
+            $this->tierPriceIndexResource,
+            $this->dimensionCollectionFactory,
+            $this->tableMaintainer,
+            2
+        );
+        $actionRows->execute($ids);
     }
 
     public function testDeletedProductsBatchProcessing()

app/code/Magento/Catalog/etc/db_schema.xml

@@ -1645,6 +1645,11 @@
         <constraint xsi:type="primary" referenceId="PRIMARY">
             <column name="id"/>
         </constraint>
+        <index referenceId="CATALOG_PRODUCT_INDEX_ENTITY_CUSTOMER_WEBSITE" indexType="btree">
+            <column name="entity_id"/>
+            <column name="customer_group_id"/>
+            <column name="website_id"/>
+        </index>
     </table>
     <table name="catalog_category_product_index_tmp" resource="default" engine="innodb"
            comment="Catalog Category Product Indexer temporary table">

app/code/Magento/Catalog/etc/db_schema_whitelist.json

@@ -992,7 +992,8 @@
         "index": {
             "CATALOG_PRODUCT_INDEX_PRICE_TMP_CUSTOMER_GROUP_ID": true,
             "CATALOG_PRODUCT_INDEX_PRICE_TMP_WEBSITE_ID": true,
-            "CATALOG_PRODUCT_INDEX_PRICE_TMP_MIN_PRICE": true
+            "CATALOG_PRODUCT_INDEX_PRICE_TMP_MIN_PRICE": true,
+            "CATALOG_PRODUCT_INDEX_ENTITY_CUSTOMER_WEBSITE": true
         },
         "constraint": {
             "PRIMARY": true