ACP2E-2673: Price partial indexing performance

- slow delete query is excluded from execution when its conditions result in 0 affected rows

Author: aplapana

app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php

@@ -437,12 +437,18 @@ function ($type) use ($productsTypes) {
      */
     private function deleteOutdatedData(array $entityIds, string $temporaryTable, string $mainTable): void
     {
+        $connection = $this->getConnection();
+        $describe = $connection->describeTable($connection->getTableName($temporaryTable));
+        if (false === $describe['entity_id']['NULLABLE']) {
+            return;
+        }
+
         $joinCondition = [
             'tmp_table.entity_id = main_table.entity_id',
             'tmp_table.customer_group_id = main_table.customer_group_id',
             'tmp_table.website_id = main_table.website_id',
         ];
-        $select = $this->getConnection()->select()
+        $select = $connection->select()
             ->from(['main_table' => $mainTable], null)
             ->joinLeft(['tmp_table' => $temporaryTable], implode(' AND ', $joinCondition), null)
             ->where('tmp_table.entity_id IS NULL')

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/Action/RowsTest.php

@@ -143,7 +143,7 @@ public function testBatchProcessing()
         $select->method('join')->willReturnSelf();
         $adapter = $this->createMock(AdapterInterface::class);
         $adapter->method('select')->willReturn($select);
-        $adapter->method('describeTable')->willReturn([]);
+        $adapter->method('describeTable')->willReturn(['entity_id' => ['NULLABLE' => true]]);
         $this->defaultIndexerResource->method('getConnection')->willReturn($adapter);
         $adapter->method('fetchAll')->with($select)->willReturn([]);