tests: add more granular ELF OS detection tests, data-driven#3098
tests: add more granular ELF OS detection tests, data-driven#3098williballenthin wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite tests/test_elf_os_detection.py to verify ELF OS detection capabilities. It defines several test fixtures representing different ELF files and their expected OS and algorithm-specific detection results (such as sh_notes, ph_notes, vdso_strings, etc.). It implements parameterized tests to validate both individual detection algorithms and the overall detect_elf_os function. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
to better support ports of this logic to other languages/runtimes
williballenthin
force-pushed
the
os-detection-data-fixtures
branch
from
8304c44 to
a6dafd0
Compare
github-actions
Bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
1 participant
to better support ports of this logic to other languages/runtimes
used Claude to help create this.
Checklist