Commit 20cea03
committed
ci: bound every job, so a hang fails instead of idling
None of the four jobs had a `timeout-minutes`, so each inherited GitHub's
six-hour default. That is what a test blocking on `accept()` with no deadline
cost the Windows leg — six hours per run, and the only reason it went
unnoticed for a day is that every run on `main` was cancelled by the next
push before it could finish.
Twenty minutes is not a budget; these legs take one to two minutes. It is a
tripwire, set about ten times longer than anything here has ever needed.
On all four rather than the one that broke. `installer` and
`installer-windows` both stand up local servers in `test-install.sh` and
`test-install.ps1` and could wedge exactly the same way, and a job that
suddenly needs twenty minutes has something wrong with it worth hearing
about whichever it is.
The comment explaining this lives once, on `build`, where it happened.1 parent bdd3815 commit 20cea03
1 file changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
35 | 47 | | |
36 | 48 | | |
37 | 49 | | |
| |||
113 | 125 | | |
114 | 126 | | |
115 | 127 | | |
| 128 | + | |
116 | 129 | | |
117 | 130 | | |
118 | 131 | | |
| |||
148 | 161 | | |
149 | 162 | | |
150 | 163 | | |
| 164 | + | |
151 | 165 | | |
152 | 166 | | |
153 | 167 | | |
| |||
268 | 282 | | |
269 | 283 | | |
270 | 284 | | |
| 285 | + | |
271 | 286 | | |
272 | 287 | | |
273 | 288 | | |
| |||
0 commit comments