From 942b35bfe7dec34134ee14a61f20caf3ece79031 Mon Sep 17 00:00:00 2001 From: AutoCodeowners Date: Mon, 14 Sep 2026 20:04:44 +0000 Subject: [PATCH 1/2] Add CODEOWNERS file --- CODEOWNERS | 1 + 1 file changed, 1 insertion(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000..2ddd5f2 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1 @@ +* @mapbox/locationai From 1cbec6ad5f4944eb04cd4e8f615fd2f4e61d0067 Mon Sep 17 00:00:00 2001 From: Matthew Podwysocki Date: Mon, 14 Sep 2026 23:49:50 -0400 Subject: [PATCH 2/2] Drop issue links a reader of this repo cannot open MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Seven comments ended with a pointer to an internal tracker. They arrived here by being carried over verbatim when this work moved, and they are the kind of reference that is worse than none: an external reader gets a link that 404s, and the repository it names is not this repository's to advertise. Nothing is lost by removing them. Every one was a trailing "see #N" on a comment that already explains the whole reasoning above it — why both opt-out variable names are honoured in the installers, why a response's headers have to be read before its body, why `--data-raw` would be the escape hatch if a text body ever needed one. The pointer was the least informative line in each. Two are reworded rather than truncated, where the sentence named the tracker as the moment something changed; they now say what is true instead of when it became true. 588 tests, both installer suites, fmt and clippy clean. --- docs/commands.md | 4 +--- scripts/install.ps1 | 2 +- scripts/install.sh | 2 +- scripts/test-install.ps1 | 3 +-- scripts/test-install.sh | 3 +-- src/executor.rs | 5 ++--- 6 files changed, 7 insertions(+), 12 deletions(-) diff --git a/docs/commands.md b/docs/commands.md index 4c4180f..14a8793 100644 --- a/docs/commands.md +++ b/docs/commands.md @@ -629,9 +629,7 @@ Two details worth knowing: is just as partial there, and the API's own document cannot carry the fact without an envelope this CLI has promised not to add — so a `-o json` consumer reading stdout alone is unaffected, and one watching stderr is - told. There is no `--all` yet; following the pages is the caller's job, - and [#117](https://github.com/mapbox/mapbox-cli-private/issues/117) tracks - changing that. + told. There is no `--all` yet; following the pages is the caller's job. - **`--id` searches the page it was given.** On a paginated listing a miss means "not on this page", which is not the same as "does not exist", so the error says which and how to look further: diff --git a/scripts/install.ps1 b/scripts/install.ps1 index 0ef900b..3143555 100644 --- a/scripts/install.ps1 +++ b/scripts/install.ps1 @@ -100,7 +100,7 @@ # installers, which are fetched and run in one line with no release notes # in front of the reader - and breaking an opt-out is the one change that # must not happen quietly. So both work here, and the new name wins when - # both are set. See mapbox/mapbox-cli-private#140. + # both are set. # # Unset, empty or whitespace is a cleared variable. `0`, `f`, `false`, `n`, # `no` and `off` are clap's false spellings, the same reading this script diff --git a/scripts/install.sh b/scripts/install.sh index 17627ef..b2e44c6 100755 --- a/scripts/install.sh +++ b/scripts/install.sh @@ -78,7 +78,7 @@ INSTALL_SOURCE="${MAPBOX_CLI_INSTALL_SOURCE:-}" # release notes in front of them — and breaking an opt-out is the one change # that must not happen quietly. So both work here, the new name wins when both # are set, and the old one keeps working for the Dockerfile the comment above -# describes. See mapbox/mapbox-cli-private#140. +# describes. # # Unset, empty, or whitespace: a cleared variable. `0`, `f`, `false`, `n`, `no` # and `off` are clap's false spellings, so a `0` is someone declining the diff --git a/scripts/test-install.ps1 b/scripts/test-install.ps1 index 3c65437..210a254 100644 --- a/scripts/test-install.ps1 +++ b/scripts/test-install.ps1 @@ -517,8 +517,7 @@ try { Start-Case 'MAPBOX_CLI_NO_TELEMETRY is honoured, and outranks the old name' New-CaseEnv 'telemetry-new-name' $env:MAPBOX_CLI_INSTALL_SOURCE = 'dockerfile' - # The documented name, which the binary reads and this script did not until - # mapbox/mapbox-cli-private#140. + # The documented name, which the binary reads and this script honours too. $env:MAPBOX_CLI_NO_TELEMETRY = '1' [IO.File]::WriteAllText($RequestLog, '') Invoke-Installer diff --git a/scripts/test-install.sh b/scripts/test-install.sh index bd396f5..ca51105 100755 --- a/scripts/test-install.sh +++ b/scripts/test-install.sh @@ -666,8 +666,7 @@ shim curl-recording curl CURL_LOG="${CASE_DIR}/curl-args" export MAPBOX_TEST_CURL_LOG="$CURL_LOG" -# The documented name, which the binary reads and this script did not until -# mapbox/mapbox-cli-private#140. +# The documented name, which the binary reads and this script honours too. : >"$CURL_LOG" export MAPBOX_CLI_NO_TELEMETRY=1 run_piped && status=0 || status=$? diff --git a/src/executor.rs b/src/executor.rs index fbee348..c16b4de 100644 --- a/src/executor.rs +++ b/src/executor.rs @@ -398,8 +398,7 @@ pub fn request_id(headers: &reqwest::header::HeaderMap) -> Option { /// A struct rather than three reads at the call site because `bytes()` /// consumes the response: whatever is not taken before it is unrecoverable. /// Taking only `Content-Type` is what left paginated listings truncating -/// silently and left a 500 with nothing to quote to support -/// (mapbox/mapbox-cli-private#117). +/// silently and left a 500 with nothing to quote to support. struct ResponseHeaders { /// Decides whether the body is read as text or written as bytes. content_type: String, @@ -797,7 +796,7 @@ const STDIN_PATH: &str = "-"; /// literal `@` cannot be passed this way. It costs nothing here, because every /// operation reachable with `--data` today sends JSON, and `@` is not valid /// JSON. If a text body that could start with one is ever wired up, `--data-raw` -/// is the established escape hatch — see mapbox/mapbox-cli-private#118. +/// is the established escape hatch. /// /// Read here rather than at send time so that a `--dry-run` validates the file /// too. A dry run that skipped this would describe a request that could not