From 4cf80800aada3fcf066a55a190097f2d7bc4f20f Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 31 Dec 2025 07:55:14 +0000 Subject: [PATCH] feat: Enhance AI code reviewer with documentation and test quality checks Add instructions for the Claude code reviewer to: - Check if PR changes align with documentation in docs/ directory - Flag when documented systems are modified without doc updates - Verify test quality and coverage for new features/bug fixes - Identify tests that only cover happy paths - Check for missing tests on public APIs and complex logic --- .github/workflows/claude-code-review.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index aa8ee5c6..dc66193d 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -49,6 +49,20 @@ jobs: - Reference specific files and line numbers - Skip the review entirely if there are no significant issues (just say "No issues found") + DOCUMENTATION CHECK: + - Check if the PR changes any systems documented in the `docs/` directory + - If changes affect documented systems (e.g., WebSocket party sessions, architecture), verify the docs are updated accordingly + - Flag if significant changes to documented features lack corresponding documentation updates + - Reference the specific doc file that needs updating (e.g., `docs/websocket-implementation.md`) + + TEST QUALITY CHECK: + - Verify that new features or bug fixes include appropriate tests + - Check test coverage for critical code paths (error handling, edge cases, main functionality) + - Flag tests that only cover happy paths without edge cases + - Identify missing tests for public APIs, utility functions, or complex logic + - Check that test descriptions accurately describe what's being tested + - Flag any tests that appear to be testing implementation details rather than behavior + Use the repository's CLAUDE.md for guidance on conventions. IMPORTANT: Check if a previous Claude review comment exists on this PR. If so, update it instead of creating a new comment.