Apply basic PyLint corrections to Basemap.arcgisimage method

Author: molinav

packages/basemap/src/mpl_toolkits/basemap/__init__.py

@@ -4257,9 +4257,9 @@ def pil_to_array(*args, **kwargs):
         im,c = self._cliplimb(ax,im)
         return im
 
-    def arcgisimage(self,server='http://server.arcgisonline.com/ArcGIS',\
-                 service='World_Imagery',xpixels=400,ypixels=None,\
-                 dpi=96,cachedir=None,verbose=False,**kwargs):
+    def arcgisimage(self, server="http://server.arcgisonline.com/ArcGIS",
+                    service="World_Imagery", xpixels=400, ypixels=None,
+                    dpi=96, cachedir=None, verbose=False, **kwargs):
         """
         Retrieve an image using the ArcGIS Server REST API and display it on
         the map. In order to use this method, the Basemap instance must be
@@ -4285,7 +4285,8 @@ def arcgisimage(self,server='http://server.arcgisonline.com/ArcGIS',\
                          map projection region.
         dpi              The device resolution of the exported image (dots per
                          inch, default 96).
-        cachedir         An optional directory to use as cache folder for the retrieved images.
+        cachedir         An optional directory to use as cache folder for the
+                         retrieved images.
         verbose          if True, print URL used to retrieve image (default
                          False).
         ==============   ====================================================
@@ -4295,7 +4296,7 @@ def arcgisimage(self,server='http://server.arcgisonline.com/ArcGIS',\
         returns a matplotlib.image.AxesImage instance.
         """
 
-        # fix PIL import on some versions of OSX and scipy
+        # Fix PIL import on some versions of OSX and scipy.
         try:
             from PIL import Image
         except ImportError:
@@ -4305,28 +4306,30 @@ def arcgisimage(self,server='http://server.arcgisonline.com/ArcGIS',\
                 raise ImportError("arcgisimage method requires PIL "
                                   "(http://pillow.readthedocs.io)")
 
-        if not hasattr(self,'epsg'):
+        if not hasattr(self, "epsg"):
             raise ValueError("the Basemap instance must be created using "
                              "an EPSG code (http://spatialreference.org) "
                              "in order to use the wmsmap method")
-        ax = kwargs.pop('ax', None) or self._check_ax()
-        # find the x,y values at the corner points.
+
+        ax = kwargs.pop("ax", None) or self._check_ax()
+
+        # Find the (x, y) values at the corner points.
         with warnings.catch_warnings():
             warnings.simplefilter("ignore", category=FutureWarning)
             p = pyproj.Proj(init="epsg:%s" % self.epsg, preserve_units=True)
-        xmin,ymin = p(self.llcrnrlon,self.llcrnrlat)
-        xmax,ymax = p(self.urcrnrlon,self.urcrnrlat)
+        xmin, ymin = p(self.llcrnrlon, self.llcrnrlat)
+        xmax, ymax = p(self.urcrnrlon, self.urcrnrlat)
         if self.projection in _cylproj:
-            Dateline =\
-            _geoslib.Point(self(180.,0.5*(self.llcrnrlat+self.urcrnrlat)))
-            hasDateline = Dateline.within(self._boundarypolyxy)
-            if hasDateline:
+            dateline = _geoslib.Point(self(180., 0.5 * (self.llcrnrlat + self.urcrnrlat)))
+            if dateline.within(self._boundarypolyxy):
                 raise ValueError("arcgisimage cannot handle images that cross "
                                  "the dateline for cylindrical projections")
-        # ypixels not given, find by scaling xpixels by the map aspect ratio.
+
+        # If ypixels is not given, compute it with xpixels and aspect ratio.
         if ypixels is None:
-            ypixels = int(self.aspect*xpixels)
-        # construct a URL using the ArcGIS Server REST API.
+            ypixels = int(self.aspect * xpixels)
+
+        # Construct a URL using the ArcGIS Server REST API.
         basemap_url = \
 "%s/rest/services/%s/MapServer/export?\
 bbox=%s,%s,%s,%s&\
@@ -4337,39 +4340,41 @@ def arcgisimage(self,server='http://server.arcgisonline.com/ArcGIS',\
 format=png32&\
 transparent=true&\
 f=image" %\
-(server,service,xmin,ymin,xmax,ymax,self.epsg,self.epsg,xpixels,ypixels,dpi)
-        # print URL?
-        if verbose: print(basemap_url)
+(server, service, xmin, ymin, xmax, ymax, self.epsg, self.epsg, xpixels, ypixels, dpi)
+
+        # Print URL in verbose mode.
+        if verbose:
+            print(basemap_url)
+
+        if cachedir is not None:
 
-        if cachedir != None:
             # Generate a filename for the cached file.
             filename = "%s-bbox-%s-%s-%s-%s-bboxsr%s-imagesr%s-size-%s-%s-dpi%s.png" %\
-            (service,xmin,ymin,xmax,ymax,self.epsg,self.epsg,xpixels,ypixels,dpi)
+            (service, xmin, ymin, xmax, ymax, self.epsg, self.epsg, xpixels, ypixels, dpi)
 
-             # Check if the cache directory exists, if not create it.
+            # Check if the cache directory exists, if not create it.
             if not os.path.exists(cachedir):
                 os.makedirs(cachedir)
 
             # Check if the image is already in the cachedir folder.
             cache_path = os.path.join(cachedir, filename)
-
             if os.path.isfile(cache_path):
                 if verbose:
-                    print('Image already in cache')
+                    print("Image already in cache")
                 img = Image.open(cache_path)
-                return self.imshow(img, ax=ax, origin='upper')
+                return self.imshow(img, ax=ax, origin="upper")
 
         # Retrieve image from remote server.
         import contextlib
         conn = urlopen(basemap_url)
         with contextlib.closing(conn):
             img = Image.open(conn)
             # Save to cache if requested.
-            if cachedir != None:
+            if cachedir is not None:
                 img.save(cache_path)
 
         # Return AxesImage instance.
-        return self.imshow(img, ax=ax, origin='upper')
+        return self.imshow(img, ax=ax, origin="upper")
 
     def wmsimage(self,server,\
                  xpixels=400,ypixels=None,\