Commit 210cc36
committed
fix(ci): pick the newest mcpp.exe on Windows; gate e2e 163 step 4 on xlings 0.4.69
Two CI failures from PR #280, both real and both worth fixing rather than
working around.
1. Windows e2e ran the PREVIOUS release's binary.
`MCPP_SELF=$(find target -name "mcpp.exe" -path "*/bin/*" | head -1)`
`target/` is restored from cache and keeps one directory per build
fingerprint. A version bump changes the fingerprint, so the freshly built
0.0.106 binary landed next to the cached 0.0.105 one and `head -1` returned
whichever the directory walk hit first — hence `Version mismatch:
mcpp.toml=0.0.106, --version='mcpp 0.0.105'`.
Latent all along; the version bump is just what made two candidates exist.
The Linux workflows already sort by mtime and take the newest — this brings
the five Windows/release sites in line with them.
2. e2e 163 step 4 asserted a capability the sandbox cannot have yet.
That step covers two same-short-name packages in ONE index, which needs
xlings >= 0.4.69 (openxlings/xlings#381). The sandbox xlings comes from
bootstrapping the PREVIOUS mcpp release, so CI runs 0.4.68 until 0.0.106
ships bundling 0.4.69 — a genuine chicken-and-egg, not a defect.
Step 4 now detects the sandbox xlings version and skips with a stated
reason when it is older. Properties 1-3 (short-name install, legacy FQN
install, arbitrary-filename discovery) are what this change is responsible
for and stay asserted unconditionally.
Verified both branches locally by swapping the sandbox xlings: 0.4.69 runs
step 4, 0.4.68 skips it with the reason printed.1 parent 436fca6 commit 210cc36
4 files changed
Lines changed: 60 additions & 8 deletions
File tree
- .github/workflows
- tests/e2e
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
48 | 55 | | |
49 | 56 | | |
50 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
44 | 51 | | |
45 | 52 | | |
46 | 53 | | |
| |||
59 | 66 | | |
60 | 67 | | |
61 | 68 | | |
62 | | - | |
63 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
64 | 77 | | |
65 | 78 | | |
66 | 79 | | |
| |||
116 | 129 | | |
117 | 130 | | |
118 | 131 | | |
119 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
120 | 140 | | |
121 | 141 | | |
122 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
633 | | - | |
634 | | - | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
635 | 641 | | |
636 | 642 | | |
637 | 643 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
90 | 109 | | |
91 | 110 | | |
92 | 111 | | |
| |||
0 commit comments