Commit ab630fd
committed
test: assert the host's quote character, not a fixed one
The Windows runner failed `LocalIncludeDirsWithSpacesAreShellQuoted` for a
difference that is correct: shell_quote_arg emits single quotes for POSIX sh
and double for cmd.exe, and the assertion hardcoded `'`. Both the unit test
and e2e 179 now take the quote character from the platform.
e2e 179 also drops its `unix-shell` requirement. Paths with spaces are the
Windows problem — `C:\Program Files`, an account name with a space — so
skipping the test there left the platform it exists for uncovered.1 parent 222cfe4 commit ab630fd
2 files changed
Lines changed: 12 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
79 | 78 | | |
80 | 79 | | |
81 | 80 | | |
82 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
83 | 86 | | |
84 | 87 | | |
85 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
270 | | - | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
271 | 276 | | |
272 | 277 | | |
273 | 278 | | |
| |||
0 commit comments