You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(test): make --build-timeout opt-in, and put the e2e's requires on line 2
Two defects in the previous commits, both caught by asking what the change does
to projects that are not this one.
--build-timeout defaulted to 900s. That would have turned slow-but-CORRECT
builds red: one mcpp-index member builds OpenCV from source and measures 1019s
on Linux and 1289s on Windows, so a fifteen-minute ceiling fails it and blames
mcpp. The asymmetry with --timeout is real and measured, not stylistic — a test
binary running over five minutes is unusual, a cold dependency build running
over fifteen is ordinary. How long a build may take is a property of the
project, so the project says it; mcpp only has to make saying it possible, and
that is what was missing. --timeout keeps its 300s default.
178_test_observability.sh carried `# requires: gcc unix-shell` inside the header
block. run_all.sh reads that line with `sed -n '2p'`, so it was inert: the test
ran on Windows, where <unistd.h> does not exist and where the deadline runner
has no kill-by-handle path, and failed for both reasons. Moved to line 2, and
narrowed to `unix-shell` — macOS is the platform this file exists for and it has
no GCC. The fixture's sleep is now <chrono>/<thread> so the fixture can never be
the reason a run fails.
0 commit comments