Commit 2391d67
committed
fix(pkg): libuv windows -DNDEBUG — EventLoop uv_walk double-close (redis-plus-plus#575)
Windows async teardown asserts in libuv src/win/handle.c:71: EventLoop's
LoopDeleter uv_walk re-closes handles already uv_close'd by hiredis's libuv
adapter cleanup (on Windows they stay in the loop's handle queue; on unix the
closing phase unlinks them first). uv_close's UV_HANDLE_CLOSING guard makes the
second call a harmless no-op — only the assert(0) aborts. NDEBUG matches libuv
release builds (vcpkg/conan) and disables the assert. Upstream open issue
sewenew/redis-plus-plus#575; caught by PR #195 windows workspace leg.1 parent 1f12571 commit 2391d67
2 files changed
Lines changed: 20 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
103 | 112 | | |
104 | 113 | | |
105 | 114 | | |
| |||
0 commit comments