Commit 8a371a7
fix(cli): verify --templates reported a different denominator passing vs failing
The same project, the same run: "11 drift error(s) across 29 template(s)" while
red, "22 template(s) clean" once fixed. Seven templates appear to vanish on the
way to green.
Both numbers were real; neither line named its unit. The failure line divided by
every `template.*` node found — INCLUDING every one the loop `continue`s past,
which on a real project means each project-local template subtype from the
adopter's own provider. The pass line divided by BODIES verified, and an
`@kind: email` template has up to three bodies while being one template. So the
red line took credit for work it had not done, and the two lines could not be
compared with each other.
Both now count templates at least one body of which was actually examined.
Found in the drift-gate demo receipt on the public reference app — the artifact
whose entire purpose is to be checked by a skeptical reader, and the asset the
launch plan names for the Show HN capstone. Every existing assertion matched on a
substring and both phrasings contain "template(s)", so nothing could see it. The
new test asserts the PAIR — same fixture, same number passing and failing —
because the failure half alone was already correct for a single-body template.
Confirmed non-vacuous by reverting the reporting and watching it go red.
cli suite green: 678 pass, 0 fail.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NynrRND6ZUwGvq3ZUTCfxG1 parent 11af128 commit 8a371a7
3 files changed
Lines changed: 97 additions & 4 deletions
File tree
- server/typescript/packages/cli
- src/commands
- test/integration
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
10 | 27 | | |
11 | 28 | | |
12 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
581 | 581 | | |
582 | 582 | | |
583 | 583 | | |
584 | | - | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
585 | 596 | | |
586 | 597 | | |
587 | 598 | | |
| |||
645 | 656 | | |
646 | 657 | | |
647 | 658 | | |
| 659 | + | |
648 | 660 | | |
649 | 661 | | |
650 | 662 | | |
| |||
656 | 668 | | |
657 | 669 | | |
658 | 670 | | |
659 | | - | |
| 671 | + | |
660 | 672 | | |
661 | 673 | | |
662 | 674 | | |
| |||
667 | 679 | | |
668 | 680 | | |
669 | 681 | | |
| 682 | + | |
670 | 683 | | |
671 | 684 | | |
672 | 685 | | |
673 | 686 | | |
674 | | - | |
| 687 | + | |
675 | 688 | | |
676 | 689 | | |
677 | 690 | | |
678 | 691 | | |
679 | | - | |
| 692 | + | |
680 | 693 | | |
681 | 694 | | |
682 | 695 | | |
| |||
Lines changed: 63 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
181 | 244 | | |
182 | 245 | | |
183 | 246 | | |
| |||
0 commit comments