Commit bebc6e4
fix(conformance): match the reference's content-sorted spec resolution order; retire the vacuous unknown-keys case name
F12 — Java/C#/Python's SourceResolver.resolveSources processed declared
source specs in DECLARED order, while each port's own comment claimed to
mirror the TypeScript reference's `orderedPathSpecs` (`sources.ts`), which
kind-validates in declared order but then resolves in CONTENT order
(`JSON.stringify(spec)`, ascending — for a validated `path`-only spec this
reduces to an ordinal sort of the path string). The three ports' comments
were half-true: they implemented the whole-list-kind-validation half but not
the sort. With two simultaneously-unresolvable declared paths, TS's
ERR_SOURCE_UNRESOLVED names the content-first one; the other three named
whichever was declared first instead.
Verified this changes ONLY which of several unresolvable paths gets named in
the raised error, never the resolved file SET: de-duplication into the
result is order-independent by construction (a Map/LinkedHashSet/HashSet
keyed on normalized path), and file order was already outside the cross-port
contract per the corpus README. All three now sort the validated path specs
ordinally before Pass 2 (matching JS's UTF-16 code-unit string comparison —
Java's `Collections.sort` on `String`, C#'s `StringComparer.Ordinal`,
Python's `sorted(..., key=...)` on `str` all agree with it for the ASCII
paths in scope). A new unit test per port (mirroring an empirical probe
against the TS reference) declares two unresolvable paths out of content
order and asserts the content-first one is named; reverted each fix,
confirmed the wrong path was named (RED), restored, confirmed the
content-first one is (GREEN). Full per-port suites (Python 1700, Java 1476,
C# 934) stay green, so no other behavior depends on the prior declared-order
processing.
F13 — the `unknown-top-level-keys-are-ignored` corpus case is vacuous for
TypeScript: all four keys it supplies (`pending_in_git`,
`confidence_thresholds`, `extract`, `migrate`) are TS's OWN recognized
top-level config keys, so TS's `ConfigSchema` (`config.ts`, `.strict()`)
passes the case by RECOGNIZING them, not by ignoring an unknown key — the
other three ports genuinely don't know these keys and correctly ignore them,
but the case can't tell that apart from TS's different reason for the same
outcome. Renamed to
`typescript-owned-top-level-keys-do-not-affect-source-resolution` (inputs
unchanged — not weakened) and the README section rewritten to state the
narrower, TRUE claim precisely.
A genuinely unrecognized key (e.g. `"foo": 1`, unknown to all four ports) IS
a real, confirmed cross-port divergence, verified empirically:
`resolveCollection` → `loadConfig` → `ConfigSchema.parse` is `.strict()` at
the top level, so an unrecognized key throws a ZodError before source
resolution is ever reached, while Java/C#/Python all resolve successfully,
silently ignoring it. NOT added as a shared corpus case and NOT fixed: doing
either would mean changing the reference implementation
(`config.ts`/`collection.ts`, explicitly out of scope) — loosening
`ConfigSchema`'s top-level strictness has a blast radius well beyond source
resolution (every `loadConfig` caller), which is a deliberate call for a
human to make, not one this pass should make unilaterally. Documented in the
README as an open, human-reviewable follow-up rather than silently dropped.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 7513716 commit bebc6e4
8 files changed
Lines changed: 194 additions & 6 deletions
File tree
- fixtures/source-resolution-conformance
- server
- csharp
- MetaObjects.Conformance.Tests
- MetaObjects/Config
- java/metadata/src
- main/java/com/metaobjects/config
- test/java/com/metaobjects/config
- python
- src/metaobjects/config
- tests/config
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
97 | | - | |
98 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
99 | 126 | | |
100 | 127 | | |
101 | 128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
| |||
Lines changed: 45 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
28 | 32 | | |
29 | 33 | | |
30 | 34 | | |
| |||
45 | 49 | | |
46 | 50 | | |
47 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
48 | 61 | | |
49 | 62 | | |
50 | 63 | | |
| |||
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
62 | 73 | | |
63 | 74 | | |
64 | 75 | | |
| |||
73 | 84 | | |
74 | 85 | | |
75 | 86 | | |
| 87 | + | |
76 | 88 | | |
77 | 89 | | |
78 | 90 | | |
| |||
Lines changed: 68 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
75 | 84 | | |
76 | 85 | | |
77 | | - | |
| 86 | + | |
78 | 87 | | |
79 | 88 | | |
80 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
68 | 82 | | |
69 | 83 | | |
70 | 84 | | |
| |||
0 commit comments