-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add codespell to micropython-lib. #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d620d98 to
90abb4f
Compare
d108cc8 to
09160fd
Compare
Signed-off-by: Jos Verlinde <Jos.Verlinde@Microsoft.com>
09160fd to
3cee61c
Compare
| # | ||
| # Generally endpoint STALL is handled automatically, but there are some | ||
| # device classes that need to explicitly stall or unstall an endpoint | ||
| # device classes that need to explicitly stall or uninstall an endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to stay as "unstall" because it's the opposite of "stall".
Maybe changing it to "un-stall" would be best? It seems that codespell doesn't complain about "un-stall".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that was what was intended.
Un-stall does make more sense to me as a non-native speaker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Spelling preferences based on codespell configuration. Signed-off-by: Jos Verlinde <Jos.Verlinde@Microsoft.com>
3cee61c to
5c376af
Compare
|
Done |
Add the codespell configuration based on the micropython/micropython repo.
this was triggered by recent fixes and a comment from Damien
Codespell configuration with:
tools/ignore_words.txtGitHub action runs on Push and PR
runs codespell on commit.
3rd commit is the only code change. Therequestsmodule has a typo in the name a a variable (formated-->formatted)While this is a minor code change I did bump the version for that module.Example:
Testing
Tested locally and in CI
Labeled as Docs- as there is no 🔨tools label