From 303293d729dcc1f9b05b9e3ee1f9906ca056a9e9 Mon Sep 17 00:00:00 2001
From: Sasa Junuzovic <44276455+microsasa@users.noreply.github.com>
Date: Sat, 18 Apr 2026 14:04:53 -0700
Subject: [PATCH] fix(parser): remove isinstance checks and relocate __all__
 (#988)

- Remove isinstance in _insert_events_entry by accepting Sequence[SessionEvent]
  and calling tuple() unconditionally.
- Unify get_all_sessions event type to list[SessionEvent] so the isinstance
  guard before _build_session_summary_with_meta is no longer needed.
- Move __all__ from mid-import-block to after all imports, matching the
  convention used by other modules in the package.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/copilot_usage/parser.py | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/src/copilot_usage/parser.py b/src/copilot_usage/parser.py
index 9f0729a8..b964f377 100644
--- a/src/copilot_usage/parser.py
+++ b/src/copilot_usage/parser.py
@@ -8,6 +8,7 @@
 import dataclasses
 import os
 from collections import OrderedDict
+from collections.abc import Sequence
 from datetime import datetime
 from functools import lru_cache
 from pathlib import Path
@@ -16,15 +17,6 @@
 from loguru import logger
 from pydantic import BaseModel, ValidationError
 
-__all__: Final[list[str]] = [
-    "DEFAULT_SESSION_PATH",
-    "build_session_summary",
-    "discover_sessions",
-    "get_all_sessions",
-    "get_cached_events",
-    "parse_events",
-]
-
 from copilot_usage._fs_utils import lru_insert, safe_file_identity
 from copilot_usage.models import (
     CodeChanges,
@@ -40,6 +32,15 @@
     session_sort_key,
 )
 
+__all__: Final[list[str]] = [
+    "DEFAULT_SESSION_PATH",
+    "build_session_summary",
+    "discover_sessions",
+    "get_all_sessions",
+    "get_cached_events",
+    "parse_events",
+]
+
 DEFAULT_SESSION_PATH: Final[Path] = Path.home() / ".copilot" / "session-state"
 _CONFIG_PATH: Final[Path] = Path.home() / ".copilot" / "config.json"
 
@@ -185,7 +186,7 @@ def _build_fingerprint(
 def _insert_events_entry(
     events_path: Path,
     file_id: tuple[int, int] | None,
-    events: list[SessionEvent] | tuple[SessionEvent, ...],
+    events: Sequence[SessionEvent],
     end_offset: int = 0,
 ) -> None:
     """Insert parsed events into ``_EVENTS_CACHE`` with LRU eviction.
@@ -200,7 +201,7 @@ def _insert_events_entry(
     individual ``SessionEvent`` objects remain mutable and must not
     be modified by callers.
     """
-    stored = events if isinstance(events, tuple) else tuple(events)
+    stored = tuple(events)
     lru_insert(
         _EVENTS_CACHE,
         events_path,
@@ -1206,12 +1207,9 @@ def get_all_sessions(base_path: Path | None = None) -> list[SessionSummary]:
                 new_events, safe_end = _parse_events_from_offset(
                     events_path, ev_cached.end_offset
                 )
-                events: list[SessionEvent] | tuple[SessionEvent, ...] = (
-                    ev_cached.events + tuple(new_events)
-                )
+                events: list[SessionEvent] = list(ev_cached.events) + new_events
             else:
-                parsed, safe_end = _parse_events_from_offset(events_path, 0)
-                events = parsed
+                events, safe_end = _parse_events_from_offset(events_path, 0)
         except OSError as exc:
             logger.warning("Skipping unreadable session {}: {}", events_path, exc)
             continue
@@ -1227,7 +1225,7 @@ def get_all_sessions(base_path: Path | None = None) -> list[SessionSummary]:
                 stored_id = (post_id[0], safe_end)
             deferred_events.append((events_path, stored_id, events, safe_end))
         meta = _build_session_summary_with_meta(
-            list(events) if isinstance(events, tuple) else events,
+            events,
             session_dir=events_path.parent,
             events_path=events_path,
             plan_exists=plan_id is not None,