Skip to content

[Shopify] Re-enable and fix legacy pricing tests #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onbuyuka wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Shopify] Re-enable and fix legacy pricing tests #8274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11c4701
[Shopify] Re-enable pricing tests to verify CI failure
onbuyuka May 21, 2026
dfd81cb
Add probes to UnitTestCalcPriceTest to diagnose CI failure
onbuyuka May 21, 2026
878c85d
Fix AA0217 by extracting StrSubstNo format string to Label
onbuyuka May 22, 2026
3f13c1e
Use EnableExtendedPriceCalculation + SetupDefaultHandler V15 to force…
onbuyuka May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Apps/W1/Shopify/Test/Catalogs/ShpfyCatalogPricesTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ codeunit 139646 "Shpfy Catalog Prices Test"
ComparePrice: Decimal;
begin
// Creating test data.
LibraryPriceCalculation.DisableExtendedPriceCalculation();
// Extended pricing is on by default in the tenant; explicitly select the V15 handler so the legacy Sales Price / Sales Line Discount data path is exercised.
LibraryPriceCalculation.EnableExtendedPriceCalculation();
LibraryPriceCalculation.SetupDefaultHandler("Price Calculation Handler"::"Business Central (Version 15.0)");
Shop := InitializeTest.CreateShop();
Shop."Allow Line Disc." := false;
Shop.Modify();
Expand Down Expand Up @@ -112,7 +114,9 @@ codeunit 139646 "Shpfy Catalog Prices Test"
ComparePrice: Decimal;
begin
// Creating test data.
LibraryPriceCalculation.DisableExtendedPriceCalculation();
// Extended pricing is on by default in the tenant; explicitly select the V15 handler so the legacy Sales Price / Sales Line Discount data path is exercised.
LibraryPriceCalculation.EnableExtendedPriceCalculation();
LibraryPriceCalculation.SetupDefaultHandler("Price Calculation Handler"::"Business Central (Version 15.0)");
Shop := InitializeTest.CreateShop();
Shop."Allow Line Disc." := false;
Shop.Modify();
Expand Down
14 changes: 0 additions & 14 deletions src/Apps/W1/Shopify/Test/DisabledTests/ShpfyCatalogPricesTest.json
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions src/Apps/W1/Shopify/Test/DisabledTests/ShpfyProductPriceCalcTest.json
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion src/Apps/W1/Shopify/Test/Products/ShpfyProductPriceCalcTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ codeunit 139605 "Shpfy Product Price Calc. Test"
ComparePrice: Decimal;
begin
// [INIT] Initialization startup data.
LibraryPriceCalculation.DisableExtendedPriceCalculation();
// Extended pricing is on by default in the tenant; explicitly select the V15 handler so the legacy Sales Price / Sales Line Discount data path is exercised.
LibraryPriceCalculation.EnableExtendedPriceCalculation();
LibraryPriceCalculation.SetupDefaultHandler("Price Calculation Handler"::"Business Central (Version 15.0)");
Shop := InitializeTest.CreateShop();
Shop."Allow Line Disc." := false;
Shop.Modify();
Expand Down
Loading