Skip to content

Commit f471f69

Browse files
authored
Merge pull request #7242 from jenshnielsen/jenshnielsen/run_all_test_steps
Run all test steps in CI and fail at the end.
2 parents d9f3cbc + 5482fc0 commit f471f69

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

.github/workflows/pytest.yaml

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,20 +91,31 @@ jobs:
9191
echo "version=$PYRIGHT_VERSION" >> $GITHUB_OUTPUT
9292
working-directory: .github
9393
shell: bash
94-
- uses: jakebailey/pyright-action@b5d50e5cde6547546a5c4ac92e416a8c2c1a1dfe # v2.3.2
94+
95+
# below we use always to ensure that the steps are run
96+
# even if the previous steps fail. This allows users to get feedback
97+
# from both typechecking and tests even if one of them fails.
98+
- name: Run Pyright
99+
uses: jakebailey/pyright-action@b5d50e5cde6547546a5c4ac92e416a8c2c1a1dfe # v2.3.2
95100
with:
96101
version: ${{ steps.pyright-version.outputs.version }}
97-
if: ${{ !matrix.min-version }}
102+
if: ${{ !matrix.min-version && always() }}
103+
id: pyright
98104
- name: Run Mypy
99105
run: mypy -p qcodes
100-
if: ${{ !matrix.min-version }}
106+
if: ${{ !matrix.min-version && always() }}
107+
id: mypy
101108
- name: Run parallel tests
109+
if: ${{ always() }}
102110
run: |
103111
pytest -m "not serial" --cov --cov-report xml --hypothesis-profile ci --durations=20 $PYTEST_OPT tests
112+
id: parallel_tests
104113
# a subset of the tests fails when run in parallel on Windows so run those in serial here
105114
- name: Run serial tests
115+
if: ${{ always() }}
106116
run: |
107117
pytest -m "serial" -n 0 --dist no --cov --cov-report xml --cov-append --hypothesis-profile ci $PYTEST_OPT tests
118+
id: serial_tests
108119
- name: Upload coverage to Codecov
109120
uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
110121
with:

0 commit comments

Comments
 (0)