ci: Migrated GitHub Actions authentication from client secrets to OIDC#730
Open
Vamshi-Microsoft wants to merge 4 commits intomainfrom
Open
ci: Migrated GitHub Actions authentication from client secrets to OIDC#730Vamshi-Microsoft wants to merge 4 commits intomainfrom
Vamshi-Microsoft wants to merge 4 commits intomainfrom
Conversation
…d Consolidated Ubuntu & Windows workflows into a single parameterized pipeline
…r Linux and Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes significant updates to the GitHub Actions workflows, focusing on improving security by adopting OIDC-based Azure authentication, simplifying workflow options, and cleaning up unused files and permissions. The changes streamline deployment processes, remove deprecated options, and enhance consistency across workflows.
Authentication and Security Improvements:
azure/login@v2action, and updated permissions to includeid-token: writewhere required. [1] [2] [3] [4] [5]environment: productionkey to relevant jobs for improved environment management and security context. [1] [2] [3] [4]Workflow and Option Simplification:
Permissions and Cleanup:
permissionsblocks from several workflow files, relying on job-level permissions and OIDC authentication instead. [1] [2] [3] [4]Workflow File Maintenance:
.github/workflows/deploy-windows.ymlworkflow, consolidating deployment logic and reducing redundancy.Other Notable Updates:
These changes collectively improve the security, maintainability, and clarity of the CI/CD workflows.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation