feat: add conditional closing to/in FluentDrawer/FluentDialog

[sebitsi]

🙋 Feature Request

Create CanClose event to prevent closing drawer/dialog.

🤔 Expected Behavior

When user/program want to close drawer/dialog there should be central event - f.e. CanClose. If we decide that closing is not allowed, drawer/dialog can't be closed. This even should fire on all closing actions (ESC, click outside - overlay, click on top header closing action or calling dialogInstance methods (CancelAsync, CloseAsync, etc).

😯 Current Behavior

When user press ESC or click outside drawer or top right "X" button, drawer is closed without possibility to stop closing.

💁 Possible Solution

Create event CanClose(bool canClose, string result). This event sould be fired on all closing actions.
By default canClose is true. If we set this value to false closing execution is stopped and drawer/dialog remains open.

🔦 Context

Drawer/dialog could be containers of forms. Exiting without control causes data loss in editforms.
We need such event to test if data were changed. And if data were changed in need a way to prevent closing
if user decide so.

Like github in this dialog.

For our future application, this is a feature that ranks very high in priority, as data entry is a very important feature.

💻 Examples

[MarvinKlein1508]

@sebitsi in v5 this is already possible. Here you can use Modal = false ro prevent closing when clicking outside. By default the drawers come without a close button itself and this needs to be implemented by yourself.

In v4 we won't add any new features. We only provide bug fixes for this version.

See: https://fluentui-blazor-v5.azurewebsites.net/Drawer

[sebitsi]

@MarvinKlein1508 Thanks for your response.

modal=false only handles clicking outside, but not ESC key.

On other hand, clicking outside is only problem if data in drawer was changed. If not, closing drawer with any action is allowed.
So with event i suggested, conditional closing will cover all scenarios.

[sebitsi]

Hi @MarvinKlein1508. What does label "closed:done" means ?
Does this mean you will close my issue?

If I understand correctly pull-request #4843 gives the option to disable ESC on the dialog to close the dialog. However, it does not allow the program to decide whether the dialog should be closed or not. Or is it? This is what i need.

[vnbaaij]

It means the issue will be closed once the PR is merged (which is the normal process with PRs)

You control the program code, so you can decide when the parameter/dialog option should be changed, right?

[MarvinKlein1508]

@sebitsi you can also hover over the labels. We should have a description for all of them.