fix(locator): pass the timeout through in screenshot (#3232)

Author: MohammedAlkindi

playwright/_impl/_locator.py

@@ -588,6 +588,7 @@ async def screenshot(
             lambda h, timeout: h.screenshot(
                 **{**params, "timeout": timeout},
             ),
+            timeout,
         )
 
     async def aria_snapshot(

tests/async/test_locators.py

@@ -411,6 +411,13 @@ async def test_locators_should_screenshot(
     )
 
 
+async def test_locators_screenshot_should_respect_timeout(page: Page) -> None:
+    page.set_default_timeout(5_000)
+    await page.set_content("<div>hello</div>")
+    with pytest.raises(Error, match="Locator.screenshot: Timeout 500ms exceeded."):
+        await page.locator("#missing").screenshot(timeout=500)
+
+
 async def test_locators_should_return_bounding_box(page: Page, server: Server) -> None:
     await page.set_viewport_size(
         {

tests/sync/test_locators.py

@@ -394,6 +394,13 @@ def test_locators_should_screenshot(
     )
 
 
+def test_locators_screenshot_should_respect_timeout(page: Page) -> None:
+    page.set_default_timeout(5_000)
+    page.set_content("<div>hello</div>")
+    with pytest.raises(Error, match="Locator.screenshot: Timeout 500ms exceeded."):
+        page.locator("#missing").screenshot(timeout=500)
+
+
 def test_locators_should_return_bounding_box(page: Page, server: Server) -> None:
     page.set_viewport_size(
         {