Instance and trace parameters for CirqApplication#3290
Open
msoeken wants to merge 1 commit into
Open
Conversation
brad-lackey
reviewed
Jun 9, 2026
|
|
||
| circuit_or_qasm: str | cirq.CIRCUIT_LIKE | ||
| classical_control_probability: float = 0.5 | ||
| rotation_threshold: float = 1e-6 |
Contributor
There was a problem hiding this comment.
Is this sufficient? I would think this should be tied to the rotation synthesis error rate (although that is computed lower in the stack).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to pass all parameters to
trace_from_cirqfrom aCirqApplication. Before this was only possible forclassical_control_probability.classical_control_probabilityis an instance parameter, as well asrotation_threshold. The remaining parametertrack_memory_qubitsis a hyper parameter for resource estimation exploration.For now
track_memory_qubitsonly iterates of[True], thereby not changing any of the current resource estimation tasks. We need better control of the trace such that we can skip enumerating over both truth values in case there are no memory qubits in the input circuit. To enable passingFalseor both values one can call.qon the app and extend the trace query, e.g.: