Skip to content

Remove stale value utils #16162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acoates-ms wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove stale value utils #16162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdc471b
Remove stale ValueUtils unify bundle load for MS.RN and win32 dll
acoates-ms May 20, 2026
d1ef765
Change files
acoates-ms May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-87ba1472-7cf5-4a35-8e67-ee722ef8b51b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Remove stale ValueUtils unify bundle load for MS.RN and win32 dll",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/CompositionHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#pragma once

#include "CompositionHelpers.h"
#include <Utils/ValueUtils.h>
#include <Windows.Graphics.DirectX.Direct3D11.interop.h>
#include <d2d1_1.h>
#include <d3d11.h>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <Fabric/Composition/ReactNativeIsland.h>
#include <Fabric/FabricUIManagerModule.h>
#include <Utils/KeyboardUtils.h>
#include <Utils/ValueUtils.h>
#include <atlcomcli.h>
#include <winrt/Microsoft.ReactNative.Composition.Experimental.h>
#include <winrt/Microsoft.UI.Input.h>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/ContentIslandComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include <Fabric/FabricUIManagerModule.h>
#include <IReactContext.h>
#include <Utils/ValueUtils.h>
#include <winrt/Microsoft.UI.Content.h>
#include <winrt/Microsoft.UI.Input.h>
#include <winrt/Windows.UI.Composition.h>
Expand Down
2 changes: 0 additions & 2 deletions vnext/Microsoft.ReactNative/Fabric/Composition/ImageComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

#include "ImageComponentView.h"

#include <Utils/ValueUtils.h>

#include <IReactContext.h>

#include <react/renderer/components/image/ImageEventEmitter.h>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/ParagraphComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <AutoDraw.h>
#include <Fabric/ReactTaggedView.h>
#include <Utils/IcuUtils.h>
#include <Utils/ValueUtils.h>
#include <react/renderer/components/text/ParagraphShadowNode.h>
#include <react/renderer/components/text/ParagraphState.h>
#include <unicode.h>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "ScrollViewComponentView.h"

#include <Fabric/ComponentView.h>
#include <Utils/ValueUtils.h>

#pragma warning(push)
#pragma warning(disable : 4305)
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/TextDrawing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "TextDrawing.h"

#include <AutoDraw.h>
#include <Utils/ValueUtils.h>
#include <unicode.h>
#include <windows.ui.composition.interop.h>
#include <winrt/Microsoft.ReactNative.Composition.h>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <Fabric/Composition/UiaHelpers.h>
#include <Fabric/platform/react/renderer/graphics/PlatformColorUtils.h>
#include <Utils/ThemeUtils.h>
#include <Utils/ValueUtils.h>
#include <react/renderer/components/textinput/TextInputState.h>
#include <react/renderer/graphics/HostPlatformColor.h>
#include <react/renderer/textlayoutmanager/WindowsTextLayoutManager.h>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/platform/react/renderer/graphics/PlatformColorUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

#include "PlatformColorUtils.h"
#include <Utils/ThemeUtils.h>
#include <Utils/ValueUtils.h>
#include <react/renderer/graphics/Color.h>
#include <winrt/Windows.UI.ViewManagement.h>
#include "HostPlatformColor.h"
Expand Down
3 changes: 0 additions & 3 deletions vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@
<ClInclude Include="Utils\TextTransform.h" />
<ClInclude Include="Utils\TransformableText.h" />
<ClInclude Include="Utils\IcuUtils.h" />
<ClInclude Include="Utils\ValueUtils.h" />
<ClInclude Include="Utils\XamlIslandUtils.h" />
<ClInclude Include="Utils\XamlUtils.h" />
<ClInclude Include="Views\DevMenu.h" />
Expand All @@ -329,8 +328,6 @@
<PrecompiledHeader>Create</PrecompiledHeader>
</ClCompile>
<ClCompile Include="$(GeneratedFilesDir)module.g.cpp" />
<ClCompile Include="Utils\LocalBundleReader.cpp" />
<ClCompile Include="Utils\ValueUtils.cpp" />
</ItemGroup>
<ItemGroup>
<Midl Include="DocString.idl" />
Expand Down
6 changes: 0 additions & 6 deletions vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,6 @@
<ClCompile Include="Utils\LocalBundleReader.cpp">
<Filter>Utils</Filter>
</ClCompile>
<ClCompile Include="Utils\ValueUtils.cpp">
<Filter>Utils</Filter>
</ClCompile>
<ClCompile Include="Modules\CreateModules.cpp">
<Filter>Modules</Filter>
</ClCompile>
Expand Down Expand Up @@ -363,9 +360,6 @@
<ClInclude Include="Utils\StandardControlResourceKeyNames.h">
<Filter>Utils</Filter>
</ClInclude>
<ClInclude Include="Utils\ValueUtils.h">
<Filter>Utils</Filter>
</ClInclude>
<ClInclude Include="Utils\XamlIslandUtils.h">
<Filter>Utils</Filter>
</ClInclude>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Modules/AppThemeModuleUwp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <ReactPropertyBag.h>
#include <Utils/Helpers.h>
#include <Utils/ThemeUtils.h>
#include <Utils/ValueUtils.h>
#include <XamlUtils.h>
#include <functional>
#include <memory>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Modules/LinkingManagerModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

#include "pch.h"

#include <Utils/ValueUtils.h>
#include <winrt/Windows.System.h>
#include "LinkingManagerModule.h"
#include "Unicode.h"
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Modules/Timing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "Timing.h"

#include <InstanceManager.h>
#include <Utils/ValueUtils.h>
#include <XamlUtils.h>

#include <unknwnbase.h>
Expand Down
103 changes: 0 additions & 103 deletions vnext/Microsoft.ReactNative/Utils/ValueUtils.cpp
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions vnext/Microsoft.ReactNative/Utils/ValueUtils.h
View file
Open in desktop

This file was deleted.

106 changes: 0 additions & 106 deletions vnext/Microsoft.ReactNative/Views/Impl/ScrollViewUWPImplementation.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading