From aab6edac95928de14981968242eec6c60f417cb7 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Fri, 17 Jul 2026 18:13:08 -0400 Subject: [PATCH 1/3] Enable noImplicitOverride in local builds. --- rigs/local-node-rig/profiles/default/tsconfig-base.json | 1 + rigs/local-web-rig/profiles/app/tsconfig-base.json | 1 + rigs/local-web-rig/profiles/library/tsconfig-base.json | 1 + 3 files changed, 3 insertions(+) diff --git a/rigs/local-node-rig/profiles/default/tsconfig-base.json b/rigs/local-node-rig/profiles/default/tsconfig-base.json index 3da0967019..e84164de07 100644 --- a/rigs/local-node-rig/profiles/default/tsconfig-base.json +++ b/rigs/local-node-rig/profiles/default/tsconfig-base.json @@ -6,6 +6,7 @@ "compilerOptions": { "resolveJsonModule": true, "isolatedModules": true, + "noImplicitOverride": true, "target": "es2018", "outDir": "${configDir}/lib-commonjs", diff --git a/rigs/local-web-rig/profiles/app/tsconfig-base.json b/rigs/local-web-rig/profiles/app/tsconfig-base.json index 394425b7a9..14b1c5340d 100644 --- a/rigs/local-web-rig/profiles/app/tsconfig-base.json +++ b/rigs/local-web-rig/profiles/app/tsconfig-base.json @@ -6,6 +6,7 @@ "compilerOptions": { "resolveJsonModule": true, "isolatedModules": true, + "noImplicitOverride": true, "target": "es2017", "lib": [ diff --git a/rigs/local-web-rig/profiles/library/tsconfig-base.json b/rigs/local-web-rig/profiles/library/tsconfig-base.json index 16661d1228..0a72a01821 100644 --- a/rigs/local-web-rig/profiles/library/tsconfig-base.json +++ b/rigs/local-web-rig/profiles/library/tsconfig-base.json @@ -6,6 +6,7 @@ "compilerOptions": { "resolveJsonModule": true, "isolatedModules": true, + "noImplicitOverride": true, "outDir": "${configDir}/lib-esm", "declarationDir": "${configDir}/lib-dts", From b230810a9337655b5e24aaa0dab57e2a326ab95a Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Fri, 17 Jul 2026 17:47:06 -0700 Subject: [PATCH 2/3] fixup! Enable noImplicitOverride in local builds. --- .../src/markdown/CustomMarkdownEmitter.ts | 2 +- .../src/plugin/MarkdownDocumenterFeature.ts | 4 ++-- .../src/inheritedMembers/index.ts | 6 +++--- .../api-extractor-test-05/dist/tsdoc-metadata.json | 2 +- libraries/rush-lib/src/api/LastInstallFlag.ts | 2 +- .../src/api/SaveCallbackPackageJsonEditor.ts | 2 +- libraries/rush-lib/src/cli/RushCommandLineParser.ts | 2 +- libraries/rush-lib/src/cli/actions/BaseRushAction.ts | 2 +- libraries/rush-lib/src/cli/actions/UpdateAction.ts | 2 +- .../logic/installManager/WorkspaceInstallManager.ts | 8 ++++++-- libraries/rush-lib/src/logic/npm/NpmPackage.ts | 5 ++++- .../rush-lib/src/logic/operations/OperationError.ts | 4 ++-- .../src/logic/operations/ProjectLogWritable.ts | 4 ++-- libraries/rush-lib/src/logic/setup/TerminalInput.ts | 8 ++++---- .../src/logic/test/BaseInstallManager.test.ts | 7 ++++++- libraries/rushell/src/AstNode.ts | 12 ++++++------ libraries/stream-collator/src/CollatedWriter.ts | 2 +- .../doc-plugin-rush-stack/src/RushStackFeature.ts | 6 +++--- .../src/test/AmazonS3Client.test.ts | 2 +- .../src/HashedFolderDependency.ts | 10 +++++----- .../src/SetPublicPathCurrentScriptPlugin.ts | 2 +- .../src/SetPublicPathPlugin.ts | 2 +- .../src/DeepImportsPlugin.ts | 2 +- 23 files changed, 55 insertions(+), 43 deletions(-) diff --git a/apps/api-documenter/src/markdown/CustomMarkdownEmitter.ts b/apps/api-documenter/src/markdown/CustomMarkdownEmitter.ts index d16710bcba..fa6637733e 100644 --- a/apps/api-documenter/src/markdown/CustomMarkdownEmitter.ts +++ b/apps/api-documenter/src/markdown/CustomMarkdownEmitter.ts @@ -33,7 +33,7 @@ export class CustomMarkdownEmitter extends MarkdownEmitter { this._apiModel = apiModel; } - public emit( + public override emit( stringBuilder: StringBuilder, docNode: DocNode, options: ICustomMarkdownEmitterOptions diff --git a/apps/api-documenter/src/plugin/MarkdownDocumenterFeature.ts b/apps/api-documenter/src/plugin/MarkdownDocumenterFeature.ts index 0666b8097b..efa45f7d72 100644 --- a/apps/api-documenter/src/plugin/MarkdownDocumenterFeature.ts +++ b/apps/api-documenter/src/plugin/MarkdownDocumenterFeature.ts @@ -75,7 +75,7 @@ const uuidMarkdownDocumenterFeature: string = '34196154-9eb3-4de0-a8c8-7e9539dfe */ export class MarkdownDocumenterFeature extends PluginFeature { /** {@inheritdoc PluginFeature.context} */ - public context!: MarkdownDocumenterFeatureContext; + public override context!: MarkdownDocumenterFeatureContext; /** * This event occurs before each markdown file is written. It provides an opportunity to customize the @@ -94,7 +94,7 @@ export class MarkdownDocumenterFeature extends PluginFeature { // (implemented by child class) } - public static [Symbol.hasInstance](instance: object): boolean { + public static override [Symbol.hasInstance](instance: object): boolean { return TypeUuid.isInstanceOf(instance, uuidMarkdownDocumenterFeature); } } diff --git a/build-tests/api-documenter-scenarios/src/inheritedMembers/index.ts b/build-tests/api-documenter-scenarios/src/inheritedMembers/index.ts index 72ecba86fe..a5f0cb269c 100644 --- a/build-tests/api-documenter-scenarios/src/inheritedMembers/index.ts +++ b/build-tests/api-documenter-scenarios/src/inheritedMembers/index.ts @@ -41,14 +41,14 @@ export class Class2 extends Namespace1.Class3 { /** Some method. Overrides `Class3.someMethod`. */ // eslint-disable-next-line @typescript-eslint/explicit-member-accessibility - someMethod(x: boolean): void {} + override someMethod(x: boolean): void {} } /** @public */ export class Class1 extends Class2 { /** A second prop. Overrides `Class2.secondProp`. */ // eslint-disable-next-line @typescript-eslint/explicit-member-accessibility - secondProp: boolean; + override secondProp: boolean; /** A fourth prop */ // eslint-disable-next-line @typescript-eslint/explicit-member-accessibility @@ -56,7 +56,7 @@ export class Class1 extends Class2 { /** Some overload. Overrides `Class3.someOverload`. */ // eslint-disable-next-line @typescript-eslint/explicit-member-accessibility - someOverload(x: boolean | string): void {} + override someOverload(x: boolean | string): void {} } /** @public */ diff --git a/build-tests/api-extractor-test-05/dist/tsdoc-metadata.json b/build-tests/api-extractor-test-05/dist/tsdoc-metadata.json index 3f4854626f..ccb284c320 100644 --- a/build-tests/api-extractor-test-05/dist/tsdoc-metadata.json +++ b/build-tests/api-extractor-test-05/dist/tsdoc-metadata.json @@ -5,7 +5,7 @@ "toolPackages": [ { "packageName": "@microsoft/api-extractor", - "packageVersion": "7.58.10" + "packageVersion": "7.58.11" } ] } diff --git a/libraries/rush-lib/src/api/LastInstallFlag.ts b/libraries/rush-lib/src/api/LastInstallFlag.ts index ab854ac6ef..a0af3df9dd 100644 --- a/libraries/rush-lib/src/api/LastInstallFlag.ts +++ b/libraries/rush-lib/src/api/LastInstallFlag.ts @@ -89,7 +89,7 @@ export class LastInstallFlag extends FlagFile> { /** * Returns true if the file exists and the contents match the current state. */ - public async isValidAsync(): Promise { + public override async isValidAsync(): Promise { return await this._isValidAsync(false, {}); } diff --git a/libraries/rush-lib/src/api/SaveCallbackPackageJsonEditor.ts b/libraries/rush-lib/src/api/SaveCallbackPackageJsonEditor.ts index 5b755212ea..cf4f5028b4 100644 --- a/libraries/rush-lib/src/api/SaveCallbackPackageJsonEditor.ts +++ b/libraries/rush-lib/src/api/SaveCallbackPackageJsonEditor.ts @@ -24,7 +24,7 @@ export class SaveCallbackPackageJsonEditor extends PackageJsonEditor { return new SaveCallbackPackageJsonEditor(options); } - public async saveIfModifiedAsync(): Promise { + public override async saveIfModifiedAsync(): Promise { const modified: boolean = await super.saveIfModifiedAsync(); if (this._onSaved) { this._onSaved(this.saveToObject()); diff --git a/libraries/rush-lib/src/cli/RushCommandLineParser.ts b/libraries/rush-lib/src/cli/RushCommandLineParser.ts index 75fa5cf536..47f2b3a640 100644 --- a/libraries/rush-lib/src/cli/RushCommandLineParser.ts +++ b/libraries/rush-lib/src/cli/RushCommandLineParser.ts @@ -233,7 +233,7 @@ export class RushCommandLineParser extends CommandLineParser { this.telemetry?.flush(); } - public async executeAsync(args?: string[]): Promise { + public override async executeAsync(args?: string[]): Promise { // debugParameter will be correctly parsed during super.executeAsync(), so manually parse here. this._terminalProvider.verboseEnabled = this._terminalProvider.debugEnabled = process.argv.indexOf('--debug') >= 0; diff --git a/libraries/rush-lib/src/cli/actions/BaseRushAction.ts b/libraries/rush-lib/src/cli/actions/BaseRushAction.ts index 85469814a8..45444525d1 100644 --- a/libraries/rush-lib/src/cli/actions/BaseRushAction.ts +++ b/libraries/rush-lib/src/cli/actions/BaseRushAction.ts @@ -115,7 +115,7 @@ export abstract class BaseRushAction extends BaseConfiglessRushAction { return this._eventHooksManager; } - protected readonly rushConfiguration!: RushConfiguration; + protected override readonly rushConfiguration!: RushConfiguration; protected override async onExecuteAsync(): Promise { if (!this.rushConfiguration) { diff --git a/libraries/rush-lib/src/cli/actions/UpdateAction.ts b/libraries/rush-lib/src/cli/actions/UpdateAction.ts index f503656bfc..5fc74900e0 100644 --- a/libraries/rush-lib/src/cli/actions/UpdateAction.ts +++ b/libraries/rush-lib/src/cli/actions/UpdateAction.ts @@ -71,7 +71,7 @@ export class UpdateAction extends BaseInstallAction { }); } - protected async runAsync(): Promise { + protected override async runAsync(): Promise { await this.parser.pluginManager.updateAsync(); if (this.parser.pluginManager.error) { diff --git a/libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts b/libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts index da941a9ffd..d70a63a1e8 100644 --- a/libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts +++ b/libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts @@ -550,7 +550,7 @@ export class WorkspaceInstallManager extends BaseInstallManager { return { shrinkwrapIsUpToDate, shrinkwrapWarnings }; } - protected async canSkipInstallAsync( + protected override async canSkipInstallAsync( lastModifiedDate: Date, subspace: Subspace, variant: string | undefined @@ -887,7 +887,11 @@ export class WorkspaceInstallManager extends BaseInstallManager { * Used when invoking the NPM tool. Appends the common configuration options * to the command-line. */ - protected pushConfigurationArgs(args: string[], options: IInstallManagerOptions, subspace: Subspace): void { + protected override pushConfigurationArgs( + args: string[], + options: IInstallManagerOptions, + subspace: Subspace + ): void { super.pushConfigurationArgs(args, options, subspace); // Add workspace-specific args diff --git a/libraries/rush-lib/src/logic/npm/NpmPackage.ts b/libraries/rush-lib/src/logic/npm/NpmPackage.ts index 354b32475a..6afb3cb1b4 100644 --- a/libraries/rush-lib/src/logic/npm/NpmPackage.ts +++ b/libraries/rush-lib/src/logic/npm/NpmPackage.ts @@ -91,7 +91,10 @@ export class NpmPackage extends BasePackage { * @param targetFolderName - Filename where it should have been installed * Example: `C:\MyRepo\common\temp\node_modules\@rush-temp\project1` */ - public static createVirtualTempPackage(packageJsonFilename: string, installFolderName: string): NpmPackage { + public static override createVirtualTempPackage( + packageJsonFilename: string, + installFolderName: string + ): NpmPackage { const packageJson: IPackageJson = JsonFile.load(packageJsonFilename); const npmPackage: readPackageTree.Node = { children: [], diff --git a/libraries/rush-lib/src/logic/operations/OperationError.ts b/libraries/rush-lib/src/logic/operations/OperationError.ts index ac5d803016..21a9446c6c 100644 --- a/libraries/rush-lib/src/logic/operations/OperationError.ts +++ b/libraries/rush-lib/src/logic/operations/OperationError.ts @@ -14,11 +14,11 @@ export class OperationError extends Error { this._type = type; } - public get message(): string { + public override get message(): string { return `[${this._type}] '${super.message}'`; } - public toString(): string { + public override toString(): string { return this.message; } } diff --git a/libraries/rush-lib/src/logic/operations/ProjectLogWritable.ts b/libraries/rush-lib/src/logic/operations/ProjectLogWritable.ts index e486d8b672..c11888a6b0 100644 --- a/libraries/rush-lib/src/logic/operations/ProjectLogWritable.ts +++ b/libraries/rush-lib/src/logic/operations/ProjectLogWritable.ts @@ -119,7 +119,7 @@ export class JsonLFileWritable extends TerminalWritable { this._writer.write(JSON.stringify(chunk) + '\n'); } - protected onClose(): void { + protected override onClose(): void { if (this._writer) { try { this._writer.close(); @@ -176,7 +176,7 @@ export class SplitLogFileWritable extends TerminalWritable { } } - protected onClose(): void { + protected override onClose(): void { if (this._logWriter) { try { this._logWriter.close(); diff --git a/libraries/rush-lib/src/logic/setup/TerminalInput.ts b/libraries/rush-lib/src/logic/setup/TerminalInput.ts index 84546ddce9..90c5ec56bc 100644 --- a/libraries/rush-lib/src/logic/setup/TerminalInput.ts +++ b/libraries/rush-lib/src/logic/setup/TerminalInput.ts @@ -35,7 +35,7 @@ class YesNoKeyboardLoop extends KeyboardLoop { this.options = options; } - protected onStart(): void { + protected override onStart(): void { this.stderr.write(Colorize.green('==>') + ' '); this.stderr.write(Colorize.bold(this.options.message)); let optionSuffix: string = ''; @@ -53,7 +53,7 @@ class YesNoKeyboardLoop extends KeyboardLoop { this.stderr.write(' ' + Colorize.bold(optionSuffix) + ' '); } - protected onKeypress(character: string, key: readline.Key): void { + protected override onKeypress(character: string, key: readline.Key): void { if (this.result !== undefined) { return; } @@ -102,7 +102,7 @@ class PasswordKeyboardLoop extends KeyboardLoop { return this.stderr.columns ? this.stderr.columns : 80; } - protected onStart(): void { + protected override onStart(): void { this.result = ''; readline.cursorTo(this.stderr, 0); @@ -118,7 +118,7 @@ class PasswordKeyboardLoop extends KeyboardLoop { this._startX = AnsiEscape.removeCodes(line).length % this._getLineWrapWidth(); } - protected onKeypress(character: string, key: readline.Key): void { + protected override onKeypress(character: string, key: readline.Key): void { switch (key.name) { case 'enter': case 'return': diff --git a/libraries/rush-lib/src/logic/test/BaseInstallManager.test.ts b/libraries/rush-lib/src/logic/test/BaseInstallManager.test.ts index 21a2f460d3..7ecf61071f 100644 --- a/libraries/rush-lib/src/logic/test/BaseInstallManager.test.ts +++ b/libraries/rush-lib/src/logic/test/BaseInstallManager.test.ts @@ -36,7 +36,12 @@ class FakeBaseInstallManager extends BaseInstallManager { protected postInstallAsync(): Promise { return Promise.resolve(); } - public pushConfigurationArgs(args: string[], options: IInstallManagerOptions, subspace: Subspace): void { + + public override pushConfigurationArgs( + args: string[], + options: IInstallManagerOptions, + subspace: Subspace + ): void { return super.pushConfigurationArgs(args, options, subspace); } } diff --git a/libraries/rushell/src/AstNode.ts b/libraries/rushell/src/AstNode.ts index 4ef0b382ef..7dc29ccfca 100644 --- a/libraries/rushell/src/AstNode.ts +++ b/libraries/rushell/src/AstNode.ts @@ -78,7 +78,7 @@ export abstract class AstBaseNode { * Represents a complete script that can be executed. */ export class AstScript extends AstBaseNode { - public readonly kind: AstKind.Script = AstKind.Script; + public override readonly kind: AstKind.Script = AstKind.Script; public body: AstNode | undefined; @@ -93,7 +93,7 @@ export class AstScript extends AstBaseNode { * Represents the "&&" operator, which is used to join two individual commands. */ export class AstAndIf extends AstBaseNode { - public readonly kind: AstKind.AndIf = AstKind.AndIf; + public override readonly kind: AstKind.AndIf = AstKind.AndIf; /** * The command that executes first, and always. @@ -119,7 +119,7 @@ export class AstAndIf extends AstBaseNode { * Represents a command. For example, the name of an executable to be started. */ export class AstCommand extends AstBaseNode { - public readonly kind: AstKind.Command = AstKind.Command; + public override readonly kind: AstKind.Command = AstKind.Command; public commandPath: AstCompoundWord | undefined; public arguments: AstCompoundWord[] = []; @@ -136,7 +136,7 @@ export class AstCommand extends AstBaseNode { * Represents a compound word, e.g. "--the-thing" or "./the/thing". */ export class AstCompoundWord extends AstBaseNode { - public readonly kind: AstKind.CompoundWord = AstKind.CompoundWord; + public override readonly kind: AstKind.CompoundWord = AstKind.CompoundWord; public readonly parts: AstNode[] = []; @@ -149,7 +149,7 @@ export class AstCompoundWord extends AstBaseNode { * Represents an environment variable expansion expression, e.g. "${VARIABLE}" */ export class AstVariableExpansion extends AstBaseNode { - public readonly kind: AstKind.VariableExpansion = AstKind.VariableExpansion; + public override readonly kind: AstKind.VariableExpansion = AstKind.VariableExpansion; protected override collectChildNodesInto(nodes: AstNode[]): void { // no children @@ -160,7 +160,7 @@ export class AstVariableExpansion extends AstBaseNode { * Represents some plain text. */ export class AstText extends AstBaseNode { - public readonly kind: AstKind.Text = AstKind.Text; + public override readonly kind: AstKind.Text = AstKind.Text; public token: Token | undefined; diff --git a/libraries/stream-collator/src/CollatedWriter.ts b/libraries/stream-collator/src/CollatedWriter.ts index a9fb2c9152..8b062676db 100644 --- a/libraries/stream-collator/src/CollatedWriter.ts +++ b/libraries/stream-collator/src/CollatedWriter.ts @@ -50,7 +50,7 @@ export class CollatedWriter extends TerminalWritable { } /** {@inheritDoc @rushstack/terminal#TerminalWritable.onClose} */ - public onClose(): void { + public override onClose(): void { this._collator._writerClose(this, this._bufferedChunks); } diff --git a/repo-scripts/doc-plugin-rush-stack/src/RushStackFeature.ts b/repo-scripts/doc-plugin-rush-stack/src/RushStackFeature.ts index 5af1e34684..8ecdee8f0d 100644 --- a/repo-scripts/doc-plugin-rush-stack/src/RushStackFeature.ts +++ b/repo-scripts/doc-plugin-rush-stack/src/RushStackFeature.ts @@ -25,12 +25,12 @@ interface INavigationFile { export class RushStackFeature extends MarkdownDocumenterFeature { private _apiItemsWithPages: Set = new Set(); - public onInitialized(): void { + public override onInitialized(): void { // eslint-disable-next-line no-console console.log('RushStackFeature: onInitialized()'); } - public onBeforeWritePage(eventArgs: IMarkdownDocumenterFeatureOnBeforeWritePageArgs): void { + public override onBeforeWritePage(eventArgs: IMarkdownDocumenterFeatureOnBeforeWritePageArgs): void { // Add the Jekyll header const header: string = [ '---', @@ -45,7 +45,7 @@ export class RushStackFeature extends MarkdownDocumenterFeature { this._apiItemsWithPages.add(eventArgs.apiItem); } - public onFinished(eventArgs: IMarkdownDocumenterFeatureOnFinishedArgs): void { + public override onFinished(eventArgs: IMarkdownDocumenterFeatureOnFinishedArgs): void { const navigationFile: INavigationFile = { api_nav: [ { diff --git a/rush-plugins/rush-amazon-s3-build-cache-plugin/src/test/AmazonS3Client.test.ts b/rush-plugins/rush-amazon-s3-build-cache-plugin/src/test/AmazonS3Client.test.ts index 2cdfe16877..a4f2e104e5 100644 --- a/rush-plugins/rush-amazon-s3-build-cache-plugin/src/test/AmazonS3Client.test.ts +++ b/rush-plugins/rush-amazon-s3-build-cache-plugin/src/test/AmazonS3Client.test.ts @@ -49,7 +49,7 @@ class MockedDate extends Date { super(2020, 3, 18, 12, 32, 42, 493); } - public toISOString(): string { + public override toISOString(): string { return '2020-04-18T12:32:42.493Z'; } } diff --git a/webpack/hashed-folder-copy-plugin/src/HashedFolderDependency.ts b/webpack/hashed-folder-copy-plugin/src/HashedFolderDependency.ts index 078f3929a2..70c51d2133 100644 --- a/webpack/hashed-folder-copy-plugin/src/HashedFolderDependency.ts +++ b/webpack/hashed-folder-copy-plugin/src/HashedFolderDependency.ts @@ -57,7 +57,7 @@ export function getHashedFolderDependencyForWebpackInstance(webpack: typeof impo function _getHashedFolderDependencyForWebpackInstance(webpack: typeof import('webpack')): IExports { class HashedFolderDependencyTemplate extends webpack.dependencies.NullDependency.Template { - public apply( + public override apply( { range, expression }: HashedFolderDependency, source: webpack.sources.ReplaceSource, templateContext: DependencyTemplateContext @@ -102,7 +102,7 @@ function _getHashedFolderDependencyForWebpackInstance(webpack: typeof import('we } } - public updateHash(hash: WebpackHash, context: UpdateHashContextDependency): void { + public override updateHash(hash: WebpackHash, context: UpdateHashContextDependency): void { if (!this._hashUpdate) { const requireFolderOptionsStr: string = JSON.stringify(this.requireFolderOptions); this._hashUpdate = `${requireFolderOptionsStr}|${this.range}`; @@ -111,18 +111,18 @@ function _getHashedFolderDependencyForWebpackInstance(webpack: typeof import('we hash.update(this._hashUpdate); } - public getModuleEvaluationSideEffectsState(moduleGraph: webpack.ModuleGraph): ConnectionState { + public override getModuleEvaluationSideEffectsState(moduleGraph: webpack.ModuleGraph): ConnectionState { return false; } - public serialize(context: ObjectSerializerContext): void { + public override serialize(context: ObjectSerializerContext): void { const { write } = context; write(this.requireFolderOptions); write(this.range); super.serialize(context); } - public deserialize(context: ObjectDeserializerContext): void { + public override deserialize(context: ObjectDeserializerContext): void { const { read } = context; this.requireFolderOptions = read() as IRequireFolderOptions; this.range = read() as Range; diff --git a/webpack/set-webpack-public-path-plugin/src/SetPublicPathCurrentScriptPlugin.ts b/webpack/set-webpack-public-path-plugin/src/SetPublicPathCurrentScriptPlugin.ts index a6101c0cc2..3128f103b7 100644 --- a/webpack/set-webpack-public-path-plugin/src/SetPublicPathCurrentScriptPlugin.ts +++ b/webpack/set-webpack-public-path-plugin/src/SetPublicPathCurrentScriptPlugin.ts @@ -36,7 +36,7 @@ export class SetPublicPathCurrentScriptPlugin extends SetPublicPathPluginBase { super('publicPath', thisWebpack.RuntimeModule.STAGE_BASIC); } - public generate(): string { + public override generate(): string { return [ `var ${PUBLIC_PATH_VARIABLE_NAME} = ${CURRENT_SCRIPT_VARIABLE_NAME} ? ${CURRENT_SCRIPT_VARIABLE_NAME}.src : '';`, `${thisWebpack.RuntimeGlobals.publicPath} = ${PUBLIC_PATH_VARIABLE_NAME}.slice(0, ${PUBLIC_PATH_VARIABLE_NAME}.lastIndexOf('/') + 1);` diff --git a/webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts b/webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts index c328e320b1..a380fa9198 100644 --- a/webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts +++ b/webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts @@ -130,7 +130,7 @@ export class SetPublicPathPlugin extends SetPublicPathPluginBase { this._pluginOptions = pluginOptions; } - public generate(): string { + public override generate(): string { const { name: regexpName, isTokenized: regexpIsTokenized, diff --git a/webpack/webpack-deep-imports-plugin/src/DeepImportsPlugin.ts b/webpack/webpack-deep-imports-plugin/src/DeepImportsPlugin.ts index ff5b2327d8..6525b36025 100644 --- a/webpack/webpack-deep-imports-plugin/src/DeepImportsPlugin.ts +++ b/webpack/webpack-deep-imports-plugin/src/DeepImportsPlugin.ts @@ -120,7 +120,7 @@ export class DeepImportsPlugin extends DllPlugin { this._dTsFilesInputFolderName = dTsFilesInputFolderName; } - public apply(compiler: Compiler): void { + public override apply(compiler: Compiler): void { super.apply(compiler); const { WebpackError } = compiler.webpack; From 915d66512c0e6c76610269b9080b5b4703f8d6b3 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Fri, 17 Jul 2026 17:47:44 -0700 Subject: [PATCH 3/3] Rush change. --- ...enable-noImplicitOverride_2026-07-18-00-45-25.json | 11 +++++++++++ ...enable-noImplicitOverride_2026-07-18-00-45-25.json | 11 +++++++++++ ...enable-noImplicitOverride_2026-07-18-00-45-25.json | 11 +++++++++++ ...enable-noImplicitOverride_2026-07-18-00-45-25.json | 11 +++++++++++ ...enable-noImplicitOverride_2026-07-18-00-45-25.json | 11 +++++++++++ 5 files changed, 55 insertions(+) create mode 100644 common/changes/@microsoft/api-documenter/enable-noImplicitOverride_2026-07-18-00-45-25.json create mode 100644 common/changes/@microsoft/rush/enable-noImplicitOverride_2026-07-18-00-45-25.json create mode 100644 common/changes/@rushstack/hashed-folder-copy-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json create mode 100644 common/changes/@rushstack/set-webpack-public-path-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json create mode 100644 common/changes/@rushstack/stream-collator/enable-noImplicitOverride_2026-07-18-00-45-25.json diff --git a/common/changes/@microsoft/api-documenter/enable-noImplicitOverride_2026-07-18-00-45-25.json b/common/changes/@microsoft/api-documenter/enable-noImplicitOverride_2026-07-18-00-45-25.json new file mode 100644 index 0000000000..771f7e84c7 --- /dev/null +++ b/common/changes/@microsoft/api-documenter/enable-noImplicitOverride_2026-07-18-00-45-25.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "type": "none", + "packageName": "@microsoft/api-documenter" + } + ], + "packageName": "@microsoft/api-documenter", + "email": "iclanton@users.noreply.github.com" +} \ No newline at end of file diff --git a/common/changes/@microsoft/rush/enable-noImplicitOverride_2026-07-18-00-45-25.json b/common/changes/@microsoft/rush/enable-noImplicitOverride_2026-07-18-00-45-25.json new file mode 100644 index 0000000000..efcd84c45f --- /dev/null +++ b/common/changes/@microsoft/rush/enable-noImplicitOverride_2026-07-18-00-45-25.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "type": "none", + "packageName": "@microsoft/rush" + } + ], + "packageName": "@microsoft/rush", + "email": "iclanton@users.noreply.github.com" +} \ No newline at end of file diff --git a/common/changes/@rushstack/hashed-folder-copy-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json b/common/changes/@rushstack/hashed-folder-copy-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json new file mode 100644 index 0000000000..3d00044f95 --- /dev/null +++ b/common/changes/@rushstack/hashed-folder-copy-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "type": "none", + "packageName": "@rushstack/hashed-folder-copy-plugin" + } + ], + "packageName": "@rushstack/hashed-folder-copy-plugin", + "email": "iclanton@users.noreply.github.com" +} \ No newline at end of file diff --git a/common/changes/@rushstack/set-webpack-public-path-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json b/common/changes/@rushstack/set-webpack-public-path-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json new file mode 100644 index 0000000000..d68748afb1 --- /dev/null +++ b/common/changes/@rushstack/set-webpack-public-path-plugin/enable-noImplicitOverride_2026-07-18-00-45-25.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "type": "none", + "packageName": "@rushstack/set-webpack-public-path-plugin" + } + ], + "packageName": "@rushstack/set-webpack-public-path-plugin", + "email": "iclanton@users.noreply.github.com" +} \ No newline at end of file diff --git a/common/changes/@rushstack/stream-collator/enable-noImplicitOverride_2026-07-18-00-45-25.json b/common/changes/@rushstack/stream-collator/enable-noImplicitOverride_2026-07-18-00-45-25.json new file mode 100644 index 0000000000..ac72fbf9f9 --- /dev/null +++ b/common/changes/@rushstack/stream-collator/enable-noImplicitOverride_2026-07-18-00-45-25.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "type": "none", + "packageName": "@rushstack/stream-collator" + } + ], + "packageName": "@rushstack/stream-collator", + "email": "iclanton@users.noreply.github.com" +} \ No newline at end of file