Skills contributed by VS Code Client do not contain descriptions#320644
Merged
Conversation
Yoyokrazy
approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses missing skill descriptions in the chat input completion UI for agent-host-backed (AHP) sessions, so that skills contributed via client customizations surface their descriptions in the suggestion list.
Changes:
- Show
attachment.descriptionas part of completion item labels forcommandandskillattachments. - Adjust skill completion label construction to incorporate
displayName(but see review comment regarding insertion/filtering consistency).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/editor/agentHostInputCompletions.ts | Updates chat input completion item label metadata so skill/command descriptions are visible in the suggestions UI. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+136
to
140
| const label = attachment.displayName ? '/' + attachment.displayName : item.insertText.trimEnd(); | ||
| return { | ||
| label: attachment.displayName ? { label, description: attachment.displayName } : label, | ||
| label: { label, description: attachment.description }, | ||
| insertText: item.insertText, | ||
| filterText: item.insertText, |
DonJayamanne
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320531