Skip to content

There is an error in the LogSoftmax function. #107

@happy1004s

Description

@happy1004s

LogSoftmax

float max = FLT_MIN;
-->
float max = -FLT_MAX;

As you know, [FLT_MIN] represents the minimum positive value. Given the structure of the algorithm, I believe -FLT_MAX should be used instead of FLT_MIN.
Because of this, when all the input data is negative, the maximum value among the negatives is not selected. Instead, [FLT_MIN] is chosen, resulting in strange output.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions