From 8907a86fc1ba45e6566490836a78e5d8cc8cdef1 Mon Sep 17 00:00:00 2001
From: adpare <apare@mitre.org>
Date: Mon, 20 Apr 2026 17:49:00 -0400
Subject: [PATCH] fix: update software service type so revoke works as expected
 for software

---
 app/services/meta-classes/base.service.js | 5 +++--
 app/services/stix/software-service.js     | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/services/meta-classes/base.service.js b/app/services/meta-classes/base.service.js
index c5421cec..39f1272d 100644
--- a/app/services/meta-classes/base.service.js
+++ b/app/services/meta-classes/base.service.js
@@ -969,9 +969,10 @@ class BaseService extends ServiceWithHooks {
         details: `Object B with stixId ${data.revoking.stixId} and modified ${data.revoking.modified} not found`,
       });
     }
-    if (objectB.stix.type !== this.type) {
+    const expectedRevokingType = this.type === 'software' ? objectA.stix.type : this.type;
+    if (objectB.stix.type !== expectedRevokingType) {
       throw new BadRequestError({
-        details: `Revoking object must be of the same type (${this.type}), got ${objectB.stix.type}`,
+        details: `Revoking object must be of the same type (${expectedRevokingType}), got ${objectB.stix.type}`,
       });
     }
 
diff --git a/app/services/stix/software-service.js b/app/services/stix/software-service.js
index 896d0d9b..39ffdb1c 100644
--- a/app/services/stix/software-service.js
+++ b/app/services/stix/software-service.js
@@ -92,4 +92,4 @@ class SoftwareService extends BaseService {
   }
 }
 
-module.exports = new SoftwareService(null, softwareRepository);
+module.exports = new SoftwareService('software', softwareRepository);