fix(webui): upgrade Tiptap to address attribute prototype vulnerability

Author: chenanran555

apps/webui/package.json

@@ -16,14 +16,14 @@
 	"description": "",
 	"dependencies": {
 		"@openagentpack/playbooks": "workspace:*",
-		"@tiptap/core": "^3.27.2",
-		"@tiptap/extension-document": "^3.27.2",
-		"@tiptap/extension-mention": "^3.27.2",
-		"@tiptap/extension-paragraph": "^3.27.2",
-		"@tiptap/extension-text": "^3.27.2",
-		"@tiptap/pm": "^3.27.2",
-		"@tiptap/react": "^3.27.2",
-		"@tiptap/suggestion": "^3.27.2",
+		"@tiptap/core": "3.30.4",
+		"@tiptap/extension-document": "3.30.4",
+		"@tiptap/extension-mention": "3.30.4",
+		"@tiptap/extension-paragraph": "3.30.4",
+		"@tiptap/extension-text": "3.30.4",
+		"@tiptap/pm": "3.30.4",
+		"@tiptap/react": "3.30.4",
+		"@tiptap/suggestion": "3.30.4",
 		"lucide-react": "^1.18.0",
 		"react": "^19.2.7",
 		"react-dom": "^19.2.7",

apps/webui/tests/serialize-prompt.test.ts

@@ -3,6 +3,8 @@ import Document from "@tiptap/extension-document";
 import Mention from "@tiptap/extension-mention";
 import Paragraph from "@tiptap/extension-paragraph";
 import Text from "@tiptap/extension-text";
+import { Fragment } from "@tiptap/pm/model";
+import { ReplaceStep } from "@tiptap/pm/transform";
 import { Editor } from "@tiptap/react";
 import { editorToSubmitPrompt, fileMentionSentinel } from "@/lib/editor/serialize-prompt";
 import { createSelectedEntry } from "@/lib/hooks/selected-files";
@@ -22,6 +24,24 @@ function makeEditor(content: object) {
 }
 
 describe("editorToSubmitPrompt", () => {
+	test("splits paragraphs using a single ProseMirror model instance", () => {
+		const editor = makeEditor({
+			type: "doc",
+			content: [{ type: "paragraph", content: [{ type: "text", text: "abcd" }] }],
+		});
+		try {
+			expect(ReplaceStep.fromJSON(editor.schema, { from: 0, to: 0 }).slice.content).toBeInstanceOf(Fragment);
+			editor.commands.setTextSelection(3);
+			expect(editor.commands.splitBlock()).toBe(true);
+			expect(editor.getJSON().content).toEqual([
+				{ type: "paragraph", content: [{ type: "text", text: "ab" }] },
+				{ type: "paragraph", content: [{ type: "text", text: "cd" }] },
+			]);
+		} finally {
+			editor.destroy();
+		}
+	});
+
 	test("mention maps to sentinel via buildFileBindings", () => {
 		const editor = makeEditor({
 			type: "doc",

apps/webui/tests/tiptap-security.test.ts

@@ -0,0 +1,29 @@
+import { describe, expect, test } from "bun:test";
+import { mergeAttributes } from "@tiptap/core";
+
+describe("Tiptap attribute safety", () => {
+	test("does not inherit attributes from a JSON-origin __proto__ key", () => {
+		// Regression for GHSA-cp6q-959q-f8rh; use an inert marker instead of executable attributes.
+		const untrustedAttributes = JSON.parse('{"__proto__":{"data-inherited":"unexpected"},"title":"file"}');
+		const attributes = mergeAttributes({ class: "mention-tag" }, untrustedAttributes);
+
+		expect(Object.getPrototypeOf(attributes)).toBe(Object.prototype);
+		expect("data-inherited" in attributes).toBe(false);
+		expect(attributes.class).toBe("mention-tag");
+		expect(attributes.title).toBe("file");
+	});
+
+	test("continues merging ordinary mention classes and attributes", () => {
+		const attributes = mergeAttributes(
+			{ class: "mention-tag", "data-type": "mention", title: "previous" },
+			{ class: "selected", "data-id": "file_1", title: "current" },
+		);
+
+		expect(attributes).toEqual({
+			class: "mention-tag selected",
+			"data-type": "mention",
+			"data-id": "file_1",
+			title: "current",
+		});
+	});
+});

bun.lock

@@ -72,12 +72,15 @@
 		"typescript": "^6.0.3"
 	},
 	"overrides": {
+		"@tiptap/extension-bubble-menu": "3.30.4",
+		"@tiptap/extension-floating-menu": "3.30.4",
 		"brace-expansion": "5.0.9",
 		"esbuild": "0.28.1",
 		"fast-equals": "5.3.3",
 		"js-yaml": "4.3.1",
 		"nanoid": "3.3.18",
-		"postcss": "8.5.23"
+		"postcss": "8.5.23",
+		"prosemirror-model": "1.25.11"
 	},
 	"trustedDependencies": [
 		"@ast-grep/cli"