Skip to content

custom launch hooks, custom java arguments and custom environment variables not saving in instance settings #7134

Description

@NobBanana

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

0.17.7

What operating systems are you seeing the problem on?

Windows

Describe the bug

I cannot turn on custom launch hooks, custom java arguments or custom environment variables on any instance (new or old, vanilla or modded). They appear to turn on and the fields become editable, but when I come back to the instance settings to check, the fields are empty and the check boxes are off again.

Steps to reproduce

  1. Go to instance settings
  2. Go to "Java and Memory" or "Launch Hooks" tab
  3. Click the checkbox for "Custom Java arguments", "Custom environment variables" or "Custom launch hooks"
  4. Click to another tab or close settings
  5. Reopen instance settings to confirm whether the settings persisted or not

Expected behavior

The settings persist upon closing instance settings

Additional context

I do not know if there should be a "save" button popping up or not. Judging from how other settings save automatically the answer is no.

Metadata

Metadata

Assignees

Labels

appRelates to Modrinth App📂 Under review[Triage] Is being reviewed by Modrinth Staff for future roadmap consideration.

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions