This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Commit b96b0ce
authored
Fix download async.series calls (#199)
- Use fs.stat instead of fs.exists because the latter is deprecated
- Properly pass errors along. `fs.exists()` had an odd signature
that was missing the typical Node.js `error` argument as its
first position, and instead always called the callback with a
single boolean.
When the `async` package was updated to 3.x, this broke this
functionality (and the tests), because it didn’t handle this
“interpret a boolean as an error” hack well.
Fix this by passing proper error objects to the callback.1 parent 3a5859a commit b96b0ce
1 file changed
+11
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
53 | 61 | | |
54 | | - | |
55 | | - | |
| 62 | + | |
| 63 | + | |
56 | 64 | | |
57 | 65 | | |
58 | 66 | | |
| |||
0 commit comments