DRIVERS-3542 Clarify that partial cursor results must be preserved in BulkWriteException on getMore error#1947
Open
GromNaN wants to merge 1 commit into
Open
DRIVERS-3542 Clarify that partial cursor results must be preserved in BulkWriteException on getMore error#1947GromNaN wants to merge 1 commit into
GromNaN wants to merge 1 commit into
Conversation
… BulkWriteException on getMore error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the "Top-Level Errors" section of the client bulk write spec to explicitly state that individual results already retrieved from the results cursor before a
getMoreerror must be preserved inBulkWriteException.partialResult.The previous wording — "individual results and/or errors have already been observed" — was ambiguous: it could be read as covering only results from previously completed batches, not documents already read from the current (partially iterated) cursor. This ambiguity led to a bug in the Java driver where those partial cursor results were discarded.
This clarification aligns the spec with the existing behavior of the Go and C/C++ drivers, which already preserve partial cursor results correctly.
Jira: https://jira.mongodb.org/browse/DRIVERS-3542